You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/08/29 12:00:20 UTC

Review Request 71405: Updated docs for the AGENT_DRAINING capability.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71405/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Qian Zhang.


Repository: mesos


Description
-------

Updated docs for the AGENT_DRAINING capability.


Diffs
-----

  docs/configuration/agent.md 760d22bfb0a47a7937cfd9542375014b024716d6 
  docs/upgrades.md ded4a8d3b7cb6808a7a3612f473e4e40e4db1490 


Diff: https://reviews.apache.org/r/71405/diff/1/


Testing
-------


Thanks,

Greg Mann


Re: Review Request 71405: Updated docs for the AGENT_DRAINING capability.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71405/#review217496
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Aug. 29, 2019, 5 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71405/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2019, 5 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docs for the AGENT_DRAINING capability.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 760d22bfb0a47a7937cfd9542375014b024716d6 
>   docs/upgrades.md ded4a8d3b7cb6808a7a3612f473e4e40e4db1490 
> 
> 
> Diff: https://reviews.apache.org/r/71405/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 71405: Updated docs for the AGENT_DRAINING capability.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71405/#review217492
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71405]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 29, 2019, noon, Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71405/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2019, noon)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docs for the AGENT_DRAINING capability.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 760d22bfb0a47a7937cfd9542375014b024716d6 
>   docs/upgrades.md ded4a8d3b7cb6808a7a3612f473e4e40e4db1490 
> 
> 
> Diff: https://reviews.apache.org/r/71405/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 71405: Updated docs for the AGENT_DRAINING capability.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71405/#review217505
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On Aug. 29, 2019, 8 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71405/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2019, 8 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docs for the AGENT_DRAINING capability.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 760d22bfb0a47a7937cfd9542375014b024716d6 
>   docs/upgrades.md ded4a8d3b7cb6808a7a3612f473e4e40e4db1490 
> 
> 
> Diff: https://reviews.apache.org/r/71405/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 71405: Updated docs for the AGENT_DRAINING capability.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71405/
-----------------------------------------------------------

(Updated Aug. 30, 2019, 1:22 p.m.)


Review request for mesos, Chun-Hung Hsiao and Qian Zhang.


Repository: mesos


Description
-------

Updated docs for the AGENT_DRAINING capability.


Diffs (updated)
-----

  docs/configuration/agent.md 760d22bfb0a47a7937cfd9542375014b024716d6 
  docs/upgrades.md 31f4a196a3baeb53e5108a164c050e5f1e422d94 


Diff: https://reviews.apache.org/r/71405/diff/2/

Changes: https://reviews.apache.org/r/71405/diff/1-2/


Testing
-------


Thanks,

Greg Mann