You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/07 10:22:34 UTC
[GitHub] [maven-shade-plugin] jenrryyou opened a new pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…
jenrryyou opened a new pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73
Shade plugin loses the meta information of orignal jar entries when copying nested jar, which make these nested jar can't be loaded by JVM。This PR is trying to fix it by modified the copy logic for JarEntry。
The jira ticket link: https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-378?filter=allopenissues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-704845082
Hi @jenrryyou ,
the PR looks good but is it possible to add a test about this case (thinking out loud DefaultShaderTest can be a base and required to generate a fake jar with nested jar using TemporaryFolder as base).
Impl side note: a PushbackInputStream can probably avoid a custom inputstream impl and still enable to test the zip header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] jenrryyou commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…
Posted by GitBox <gi...@apache.org>.
jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-705325012
Hi @rmannibucau ,
thanks for your review and comment，I will add a test for this case. As for using PushbackInputStream, it seems like a better
idea and I will try it also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] rmannibucau merged pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…
Posted by GitBox <gi...@apache.org>.
rmannibucau merged pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] jenrryyou commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…
Posted by GitBox <gi...@apache.org>.
jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-705325012
Hi @rmannibucau ,
thanks for your review and comment，I will add a test for this case. As for using PushbackInputStream, it seems like a better
idea and I will try it also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] jenrryyou commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…
Posted by GitBox <gi...@apache.org>.
jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-729328053
[MSHADE-378] Shade plugin changes the compression level of nested jar entries, see more at this [jira ticket link](https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-378?filter=allopenissues)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] jenrryyou removed a comment on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…
Posted by GitBox <gi...@apache.org>.
jenrryyou removed a comment on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-729328053
[MSHADE-378] Shade plugin changes the compression level of nested jar entries, see more at this [jira ticket link](https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-378?filter=allopenissues)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] jenrryyou commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…
Posted by GitBox <gi...@apache.org>.
jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-731699320
Hi @rmannibucau ,
Since I have no write access for this repo，I was wondering if you could merge this PR or somebody else would do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shade-plugin] jenrryyou commented on pull request #73: [MSHADE-378] Shade plugin changes the compression level of nested jar…
Posted by GitBox <gi...@apache.org>.
jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-728792839
Hi @rmannibucau ,
A test is added for this PR to verify that shade plugin wouldn't change the compression level of nested jar. By the way, ZipHeaderPeekInputStream is refined and based on PushbackInputStream now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org