You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Pan Jie (JIRA)" <ji...@apache.org> on 2009/05/19 03:14:45 UTC
[jira] Created: (SHINDIG-1064) exception when json_decode
container.js
exception when json_decode container.js
---------------------------------------
Key: SHINDIG-1064
URL: https://issues.apache.org/jira/browse/SHINDIG-1064
Project: Shindig
Issue Type: Bug
Components: PHP
Affects Versions: trunk
Reporter: Pan Jie
Priority: Minor
Fix For: trunk
After synced revision 774974, php shindig couldn't json_decode container.js
Line in container.js:
"gadgets.oauthGadgetCallbackTemplate" : "//%host%/gadgets/oauthcallback",
will be changed to
"gadgets.oauthGadgetCallbackTemplate" : ,
So json_decode failed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1064) exception when json_decode
container.js
Posted by "Pan Jie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pan Jie updated SHINDIG-1064:
-----------------------------
Attachment: 20090518.patch
1. Fixed issue by not removing string matched "//
2. Added a unittest to reproduce this issue. This unittes failed before applying this patch, and passed after applying this patch.
3. Fix warning cause by DefaultInvalidateService.php
> exception when json_decode container.js
> ---------------------------------------
>
> Key: SHINDIG-1064
> URL: https://issues.apache.org/jira/browse/SHINDIG-1064
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Affects Versions: trunk
> Reporter: Pan Jie
> Priority: Minor
> Fix For: trunk
>
> Attachments: 20090518.patch
>
>
> After synced revision 774974, php shindig couldn't json_decode container.js
> Line in container.js:
> "gadgets.oauthGadgetCallbackTemplate" : "//%host%/gadgets/oauthcallback",
> will be changed to
> "gadgets.oauthGadgetCallbackTemplate" : ,
> So json_decode failed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1064) exception when json_decode
container.js
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot resolved SHINDIG-1064.
-----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
Patch's been committed, thanks for the fix pan!
> exception when json_decode container.js
> ---------------------------------------
>
> Key: SHINDIG-1064
> URL: https://issues.apache.org/jira/browse/SHINDIG-1064
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Affects Versions: trunk
> Reporter: Pan Jie
> Assignee: Chris Chabot
> Priority: Minor
> Fix For: trunk
>
> Attachments: 20090518.patch
>
>
> After synced revision 774974, php shindig couldn't json_decode container.js
> Line in container.js:
> "gadgets.oauthGadgetCallbackTemplate" : "//%host%/gadgets/oauthcallback",
> will be changed to
> "gadgets.oauthGadgetCallbackTemplate" : ,
> So json_decode failed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.