You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/06/29 05:49:05 UTC

[GitHub] [submarine] KUAN-HSUN-LI opened a new pull request #617: SUBMARINE-871. Upgrade cglib for Ubuntu 20.04

KUAN-HSUN-LI opened a new pull request #617:
URL: https://github.com/apache/submarine/pull/617


   ### What is this PR for?
   Running userSexDictAnnotationTest will add the DICT_SUFFIX in DictAnnotation class.
   Using key with "@" will fail in cglib 3.2, but passing in cglib 3.3.
   However, cglib is using asm 7.1, submarine-cluster and submarine-rpc are using asm 5.1. We should exclude the asm in both dependencies.
   
   ### What type of PR is it?
   [Test]
   
   ### Todos
   
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-871
   
   ### How should this be tested?
   run the userSexDictAnnotationTest.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] asfgit closed pull request #617: SUBMARINE-871. Upgrade cglib for Ubuntu 20.04

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #617:
URL: https://github.com/apache/submarine/pull/617


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] asfgit closed pull request #617: SUBMARINE-871. Upgrade cglib for Ubuntu 20.04

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #617:
URL: https://github.com/apache/submarine/pull/617


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] ByronHsu commented on pull request #617: SUBMARINE-871. Upgrade cglib for Ubuntu 20.04

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #617:
URL: https://github.com/apache/submarine/pull/617#issuecomment-870455098


   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] ByronHsu commented on pull request #617: SUBMARINE-871. Upgrade cglib for Ubuntu 20.04

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #617:
URL: https://github.com/apache/submarine/pull/617#issuecomment-870455098


   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org