You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ac...@apache.org on 2016/07/05 06:45:16 UTC

camel git commit: Fixed CS

Repository: camel
Updated Branches:
  refs/heads/master bab1c2d26 -> 942da96ad


Fixed CS


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/942da96a
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/942da96a
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/942da96a

Branch: refs/heads/master
Commit: 942da96ade2e4e4736fecf738aefe8a713c26a80
Parents: bab1c2d
Author: Andrea Cosentino <an...@gmail.com>
Authored: Tue Jul 5 08:42:16 2016 +0200
Committer: Andrea Cosentino <an...@gmail.com>
Committed: Tue Jul 5 08:42:16 2016 +0200

----------------------------------------------------------------------
 .../java/org/apache/camel/util/UnsafeUriCharactersEncoder.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/942da96a/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java b/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
index 3de44f9..610876d 100644
--- a/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
+++ b/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
@@ -32,7 +32,7 @@ public final class UnsafeUriCharactersEncoder {
     private static BitSet unsafeCharactersHttp;
     private static final char[] HEX_DIGITS = {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C',
                                               'D', 'E', 'F', 'a', 'b', 'c', 'd', 'e', 'f'};
-    private static Pattern RAW_PATTERN = Pattern.compile("RAW\\([^\\)]+\\)");
+    private static Pattern rawPattern = Pattern.compile("RAW\\([^\\)]+\\)");
 
     static {
         unsafeCharactersRfc1738 = new BitSet(256);
@@ -95,7 +95,7 @@ public final class UnsafeUriCharactersEncoder {
     }
 
     private static List<Pair> checkRAW(String s) {
-        Matcher matcher = RAW_PATTERN.matcher(s);
+        Matcher matcher = rawPattern.matcher(s);
         List<Pair> answer = new ArrayList<Pair>();
         // Check all occurrences
         while (matcher.find()) {


Re: camel git commit: Fixed CS

Posted by Andrea Cosentino <an...@yahoo.com.INVALID>.
Sure.

I will do
 --
Andrea Cosentino 
----------------------------------
Apache Camel PMC Member
Apache Karaf Committer
Apache Servicemix Committer
Email: ancosen1985@yahoo.com
Twitter: @oscerd2
Github: oscerd



On Tuesday, July 5, 2016 9:28 AM, Claus Ibsen <cl...@gmail.com> wrote:
You can declare the RAW_PATTERN as final then the CS accept it as a
field in upper case.



On Tue, Jul 5, 2016 at 8:45 AM,  <ac...@apache.org> wrote:
> Repository: camel
> Updated Branches:
>   refs/heads/master bab1c2d26 -> 942da96ad
>
>
> Fixed CS
>
>
> Project: http://git-wip-us.apache.org/repos/asf/camel/repo
> Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/942da96a
> Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/942da96a
> Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/942da96a
>
> Branch: refs/heads/master
> Commit: 942da96ade2e4e4736fecf738aefe8a713c26a80
> Parents: bab1c2d
> Author: Andrea Cosentino <an...@gmail.com>
> Authored: Tue Jul 5 08:42:16 2016 +0200
> Committer: Andrea Cosentino <an...@gmail.com>
> Committed: Tue Jul 5 08:42:16 2016 +0200
>
> ----------------------------------------------------------------------
>  .../java/org/apache/camel/util/UnsafeUriCharactersEncoder.java   | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/camel/blob/942da96a/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
> ----------------------------------------------------------------------
> diff --git a/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java b/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
> index 3de44f9..610876d 100644
> --- a/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
> +++ b/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
> @@ -32,7 +32,7 @@ public final class UnsafeUriCharactersEncoder {
>      private static BitSet unsafeCharactersHttp;
>      private static final char[] HEX_DIGITS = {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C',
>                                                'D', 'E', 'F', 'a', 'b', 'c', 'd', 'e', 'f'};
> -    private static Pattern RAW_PATTERN = Pattern.compile("RAW\\([^\\)]+\\)");
> +    private static Pattern rawPattern = Pattern.compile("RAW\\([^\\)]+\\)");
>
>      static {
>          unsafeCharactersRfc1738 = new BitSet(256);
> @@ -95,7 +95,7 @@ public final class UnsafeUriCharactersEncoder {
>      }
>
>      private static List<Pair> checkRAW(String s) {
> -        Matcher matcher = RAW_PATTERN.matcher(s);
> +        Matcher matcher = rawPattern.matcher(s);
>          List<Pair> answer = new ArrayList<Pair>();
>          // Check all occurrences
>          while (matcher.find()) {
>



-- 
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2

Re: camel git commit: Fixed CS

Posted by Claus Ibsen <cl...@gmail.com>.
You can declare the RAW_PATTERN as final then the CS accept it as a
field in upper case.


On Tue, Jul 5, 2016 at 8:45 AM,  <ac...@apache.org> wrote:
> Repository: camel
> Updated Branches:
>   refs/heads/master bab1c2d26 -> 942da96ad
>
>
> Fixed CS
>
>
> Project: http://git-wip-us.apache.org/repos/asf/camel/repo
> Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/942da96a
> Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/942da96a
> Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/942da96a
>
> Branch: refs/heads/master
> Commit: 942da96ade2e4e4736fecf738aefe8a713c26a80
> Parents: bab1c2d
> Author: Andrea Cosentino <an...@gmail.com>
> Authored: Tue Jul 5 08:42:16 2016 +0200
> Committer: Andrea Cosentino <an...@gmail.com>
> Committed: Tue Jul 5 08:42:16 2016 +0200
>
> ----------------------------------------------------------------------
>  .../java/org/apache/camel/util/UnsafeUriCharactersEncoder.java   | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/camel/blob/942da96a/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
> ----------------------------------------------------------------------
> diff --git a/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java b/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
> index 3de44f9..610876d 100644
> --- a/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
> +++ b/camel-core/src/main/java/org/apache/camel/util/UnsafeUriCharactersEncoder.java
> @@ -32,7 +32,7 @@ public final class UnsafeUriCharactersEncoder {
>      private static BitSet unsafeCharactersHttp;
>      private static final char[] HEX_DIGITS = {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C',
>                                                'D', 'E', 'F', 'a', 'b', 'c', 'd', 'e', 'f'};
> -    private static Pattern RAW_PATTERN = Pattern.compile("RAW\\([^\\)]+\\)");
> +    private static Pattern rawPattern = Pattern.compile("RAW\\([^\\)]+\\)");
>
>      static {
>          unsafeCharactersRfc1738 = new BitSet(256);
> @@ -95,7 +95,7 @@ public final class UnsafeUriCharactersEncoder {
>      }
>
>      private static List<Pair> checkRAW(String s) {
> -        Matcher matcher = RAW_PATTERN.matcher(s);
> +        Matcher matcher = rawPattern.matcher(s);
>          List<Pair> answer = new ArrayList<Pair>();
>          // Check all occurrences
>          while (matcher.find()) {
>



-- 
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2