You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yf13 (via GitHub)" <gi...@apache.org> on 2024/04/16 01:08:13 UTC
[PR] arch/kconfig: revise kernel space mapping configs [nuttx]
yf13 opened a new pull request, #12154:
URL: https://github.com/apache/nuttx/pull/12154
## Summary
This treats kernel space virtual memory allocation based mappings similar to that of the user space:
- Add ARCH_KVMA_MAPPING to guard kernel mapping configs.
- Set dependency from MM_KMAP to ARCH_KVMA_MAPPING, as per commit 70de321de3f.
## Impact
None
## Testing
CI checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/kconfig: revise kernel space mapping configs [nuttx]
Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on code in PR #12154:
URL: https://github.com/apache/nuttx/pull/12154#discussion_r1569818168
##########
arch/Kconfig:
##########
@@ -722,6 +722,10 @@ config ARCH_VMA_MAPPING
bool "Support runtime memory mapping into SHM area"
default n
+config ARCH_KVMA_MAPPING
+ bool "Support kernel space virtual mmemory allocation mappings"
Review Comment:
Prompt string has been dropped in latest upate. Thanks for teaching this tip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/kconfig: revise kernel space mapping configs [nuttx]
Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on code in PR #12154:
URL: https://github.com/apache/nuttx/pull/12154#discussion_r1567140439
##########
arch/Kconfig:
##########
@@ -722,6 +722,10 @@ config ARCH_VMA_MAPPING
bool "Support runtime memory mapping into SHM area"
default n
+config ARCH_KVMA_MAPPING
Review Comment:
Similar to commit 70de321 (sorry I can't find the patch id for that commit), the dependency should be from `MM` to `ARCH`, not vice versa. If this is correct understanding, then we need a thing like `ARCH_VMA_MAPPING` to select from `MM_KMAP`, and that thing further enables both `ARCH_KMAP_VBASE` and `ARCH_KMAP_NPAGES`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/kconfig: revise kernel space mapping configs [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12154:
URL: https://github.com/apache/nuttx/pull/12154#discussion_r1566681922
##########
arch/Kconfig:
##########
@@ -722,6 +722,10 @@ config ARCH_VMA_MAPPING
bool "Support runtime memory mapping into SHM area"
default n
+config ARCH_KVMA_MAPPING
Review Comment:
why need add additional option if we just support one type of kernel memory mapping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/kconfig: revise kernel mapping configs [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12154:
URL: https://github.com/apache/nuttx/pull/12154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/kconfig: revise kernel space mapping configs [nuttx]
Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on code in PR #12154:
URL: https://github.com/apache/nuttx/pull/12154#discussion_r1567140439
##########
arch/Kconfig:
##########
@@ -722,6 +722,10 @@ config ARCH_VMA_MAPPING
bool "Support runtime memory mapping into SHM area"
default n
+config ARCH_KVMA_MAPPING
Review Comment:
Similar to commit 70de321 (sorry I can't find the patch id for that commit), the dependency should be from `MM` to `ARCH`, not vice versa.
If this is correct understanding, then we need a thing like `ARCH_VMA_MAPPING` to select from `MM_KMAP`, and that further enables `ARCH_KMAP_VBASE` and `ARCH_KMAP_NPAGES`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/kconfig: revise kernel space mapping configs [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12154:
URL: https://github.com/apache/nuttx/pull/12154#discussion_r1568984716
##########
arch/Kconfig:
##########
@@ -722,6 +722,10 @@ config ARCH_VMA_MAPPING
bool "Support runtime memory mapping into SHM area"
default n
+config ARCH_KVMA_MAPPING
+ bool "Support kernel space virtual mmemory allocation mappings"
Review Comment:
let's remove the prompt, option selected by other option should forbid to be enabled by defconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org