You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/22 09:40:55 UTC
[GitHub] [incubator-seatunnel] harveyyue opened a new pull request, #3161: [Improve][Connector-V2][Kafka] Recommend the prefix producer/consumer.override instead of kafka
harveyyue opened a new pull request, #3161:
URL: https://github.com/apache/incubator-seatunnel/pull/3161
Code changes as below:
1. Fix some typo issue
2. To identify the consumer/producer configurations, change the overrided config prefix "kafka" to producer.override and consumer.override
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] github-actions[bot] closed pull request #3161: [Improve][Connector-V2][Kafka] Recommend the prefix producer/consumer.override instead of kafka
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3161: [Improve][Connector-V2][Kafka] Recommend the prefix producer/consumer.override instead of kafka
URL: https://github.com/apache/incubator-seatunnel/pull/3161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #3161: [Improve][Connector-V2][Kafka] Recommend the prefix producer/consumer.override instead of kafka
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #3161:
URL: https://github.com/apache/incubator-seatunnel/pull/3161#issuecomment-1288309882
> @hailin0 Do we need to change the kafka prefix?
It's an incompatible change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] github-actions[bot] commented on pull request #3161: [Improve][Connector-V2][Kafka] Recommend the prefix producer/consumer.override instead of kafka
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3161:
URL: https://github.com/apache/incubator-seatunnel/pull/3161#issuecomment-1449131123
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3161: [Improve][Connector-V2][Kafka] Recommend the prefix producer/consumer.override instead of kafka
Posted by GitBox <gi...@apache.org>.
TaoZex commented on PR #3161:
URL: https://github.com/apache/incubator-seatunnel/pull/3161#issuecomment-1287768302
@hailin0 Do we need to change the kafka prefix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] github-actions[bot] commented on pull request #3161: [Improve][Connector-V2][Kafka] Recommend the prefix producer/consumer.override instead of kafka
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3161:
URL: https://github.com/apache/incubator-seatunnel/pull/3161#issuecomment-1439263512
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org