You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/08/20 06:17:37 UTC
[GitHub] [dubbo-go] codecov-commenter commented on pull request #694: Fix: Register service instance after provider config load
codecov-commenter commented on pull request #694:
URL: https://github.com/apache/dubbo-go/pull/694#issuecomment-677260114
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/694?src=pr&el=h1) Report
> Merging [#694](https://codecov.io/gh/apache/dubbo-go/pull/694?src=pr&el=desc) into [1.5.1](https://codecov.io/gh/apache/dubbo-go/commit/e3dd46ff2e4a1e54dda84a04845bc9c664c4a927&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `53.52%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5.1 #694 +/- ##
==========================================
+ Coverage 63.89% 63.93% +0.03%
==========================================
Files 239 239
Lines 12752 12795 +43
==========================================
+ Hits 8148 8180 +32
- Misses 3818 3822 +4
- Partials 786 793 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/694?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/694/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/694/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `78.48% <0.00%> (-2.31%)` | :arrow_down: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/694/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `11.91% <ø> (-3.34%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/694/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `57.27% <61.29%> (+1.57%)` | :arrow_up: |
| [config\_center/apollo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/694/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vbGlzdGVuZXIuZ28=) | `82.60% <0.00%> (-17.40%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/694/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.33% <0.00%> (-3.34%)` | :arrow_down: |
| [config\_center/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/694/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9saXN0ZW5lci5nbw==) | `45.45% <0.00%> (-2.17%)` | :arrow_down: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/694/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `80.82% <0.00%> (-1.90%)` | :arrow_down: |
| [protocol/dubbo/config.go](https://codecov.io/gh/apache/dubbo-go/pull/694/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29uZmlnLmdv) | `13.15% <0.00%> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/694/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `56.25% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go/pull/694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/694?src=pr&el=footer). Last update [e3dd46f...d58e4fa](https://codecov.io/gh/apache/dubbo-go/pull/694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org