You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/05/16 02:45:08 UTC
[GitHub] [incubator-pinot] kishoreg commented on a change in pull request
#4198: Enhance the support for BYTES data type
kishoreg commented on a change in pull request #4198: Enhance the support for BYTES data type
URL: https://github.com/apache/incubator-pinot/pull/4198#discussion_r284519103
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/data/FieldSpec.java
##########
@@ -439,6 +415,28 @@ public int size() {
throw new IllegalStateException("Cannot get number of bytes for: " + this);
}
}
+
+ /**
+ * Converts the given string value to the data type.
+ */
+ public Object convert(String value) {
Review comment:
probably not part of this PR but why is this method part of the FieldSpec?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org