You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "martinzink (via GitHub)" <gi...@apache.org> on 2023/04/13 12:35:47 UTC

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI

martinzink commented on code in PR #1538:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1165458301


##########
.github/workflows/ci.yml:
##########


Review Comment:
   Besides the reruns, since the download/upload artifact overhead is minimal separating them vs keeping them together is roughly the same cloud cpu time, but the separated one finishes considerably faster IRL (~3-4 times faster).
   When we manage to run these parallel on the same host we can reconsider merging them, but until then I think its a good idea to shorten the overall CI runtime if there are no major drawbacks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org