You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/02/11 06:48:06 UTC
[GitHub] [zeppelin] omrisk opened a new pull request #4052: [ZEPPELIN-5229] - bump flink 1.10 minor version
omrisk opened a new pull request #4052:
URL: https://github.com/apache/zeppelin/pull/4052
### What is this PR for?
Bumping flink minor version
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5229
### How should this be tested?
Automation and builds
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - no
* Is there breaking changes for older versions? - no
* Does this needs documentation? - no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4052: [ZEPPELIN-5229] - bump flink 1.10 minor version
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4052:
URL: https://github.com/apache/zeppelin/pull/4052#issuecomment-777261274
That's would be better, @omrisk maybe put them in project root pom.xml.
If that is possible, we should do the same thing for spark as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4052: [ZEPPELIN-5229] - bump flink 1.10 minor version
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4052:
URL: https://github.com/apache/zeppelin/pull/4052#issuecomment-779730018
LGTM, will merge if no more comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4052: [ZEPPELIN-5229] - bump flink 1.10 minor version
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4052:
URL: https://github.com/apache/zeppelin/pull/4052#issuecomment-777248721
Thanks @omrisk, there's another place needs to update flink version.
https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter-integration/src/test/java/org/apache/zeppelin/integration/FlinkIntegrationTest110.java#L32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] omrisk commented on pull request #4052: [ZEPPELIN-5229] - bump flink 1.10 minor version
Posted by GitBox <gi...@apache.org>.
omrisk commented on pull request #4052:
URL: https://github.com/apache/zeppelin/pull/4052#issuecomment-777269920
@zjffdu , opened this separate ticket for that https://issues.apache.org/jira/browse/ZEPPELIN-5247.
I'll try to handle soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4052: [ZEPPELIN-5229] - bump flink 1.10 minor version
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4052:
URL: https://github.com/apache/zeppelin/pull/4052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] omrisk edited a comment on pull request #4052: [ZEPPELIN-5229] - bump flink 1.10 minor version
Posted by GitBox <gi...@apache.org>.
omrisk edited a comment on pull request #4052:
URL: https://github.com/apache/zeppelin/pull/4052#issuecomment-777269920
@zjffdu , opened this separate ticket for that https://issues.apache.org/jira/browse/ZEPPELIN-5247.
I'll try to handle soon in a separate PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] omrisk commented on pull request #4052: [ZEPPELIN-5229] - bump flink 1.10 minor version
Posted by GitBox <gi...@apache.org>.
omrisk commented on pull request #4052:
URL: https://github.com/apache/zeppelin/pull/4052#issuecomment-777259136
@zjffdu, thanks, missed that, fixed.
Newbie question, should parameters like that be extracted to a `.properties` file (in a seperate issue/PR)?
So that versions can be fully managed for builds in tests with a single source for the values?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org