You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/05/21 20:16:27 UTC
[GitHub] [jena] afs opened a new pull request #747: JENA-1900: Ensure only one Log4j2Plugins.dat file shaded
afs opened a new pull request #747:
URL: https://github.com/apache/jena/pull/747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #747: JENA-1900: Ensure only one Log4j2Plugins.dat file shaded
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #747:
URL: https://github.com/apache/jena/pull/747#discussion_r428892641
##########
File path: jena-fuseki2/jena-fuseki-fulljar/pom.xml
##########
@@ -38,6 +38,12 @@
<groupId>org.apache.jena</groupId>
<artifactId>jena-fuseki-webapp</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-web</artifactId>
Review comment:
Exclude `org.apache.logging.log4j:log4j-web` -- it isn't necessary running as a single app in Jetty because there isn't a stop.unload issue. But it does contain another Log4j2Plugins.dat and this was the problem - shaing picked one, not merged them.
The general fix - the 3rd party shade transformer - didn't work reliably so the simple fix is to exclude the artifact in `jena-fuseki-fulljar`. The transformer is also very version sensitive.
The emergence fix script put in the log4j-core Log4j2Plugins.dat and does not include the log4j-web additions -- so evidence that the log4j-web isn't needed.
##########
File path: jena-fuseki2/apache-jena-fuseki/log4j2.properties
##########
@@ -47,8 +47,8 @@ logger.jetty.name = org.eclipse.jetty
logger.jetty.level = WARN
# Hide bug in Shiro 1.5.0
-logger.shiro.name = org.apache.shiro.realm.text.IniRealm
-logger.shiro.level = ERROR
Review comment:
Fix logging config mistake - should set for "org.apache.shiro" (silences two log lines as the server starts).
##########
File path: jena-fuseki2/jena-fuseki-fulljar/pom.xml
##########
@@ -73,15 +79,26 @@
<build>
<plugins>
-
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<configuration>
<shadedArtifactAttached>false</shadedArtifactAttached>
<transformers>
+ <!--
+ https://issues.apache.org/jira/browse/LOG4J2-954 - fixed at 3.0.0
+ Multiple Log4j2Plugins.dat
+ jena-fuseki-fulljar picks up one Log4j2Plugins.dat from
+ org.apache.logging.log4j:log4j-core and, unless excluded,
+ one via jena-fuseki-webapp which has org.apache.logging.log4j:log4j-core-web
+ If it becomes necessary, see: https://github.com/edwgiz/maven-shaded-log4j-transformer
+ -->
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
<mainClass>org.apache.jena.fuseki.cmd.FusekiCmd</mainClass>
+ <!-- https://issues.apache.org/jira/browse/LOG4J2-2537 -->
+ <manifestEntries>
+ <Multi-Release>true</Multi-Release>
+ </manifestEntries>
Review comment:
Logging setup when run on a java9+ JVM was outputting a warning. See LOG4J2-2537.
##########
File path: pom.xml
##########
@@ -54,7 +54,8 @@
<ver.junit>4.12</ver.junit>
<ver.slf4j>1.7.30</ver.slf4j>
- <ver.log4j2>2.13.1</ver.log4j2>
+ <ver.log4j2>2.13.3</ver.log4j2>
+ <ver.shade-plugin>3.2.3</ver.shade-plugin>
Review comment:
In trying to get the 3rd party shade transformer to work, upgrading the shade plugin and the log4j2 version were necessary so evenif not required after all, the x.x.1 updates are left in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #747: JENA-1900: Ensure only one Log4j2Plugins.dat file shaded
Posted by GitBox <gi...@apache.org>.
afs merged pull request #747:
URL: https://github.com/apache/jena/pull/747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org