You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/08/02 09:20:36 UTC

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4195: [WIP][ZEPPELIN-5469]

zjffdu commented on a change in pull request #4195:
URL: https://github.com/apache/zeppelin/pull/4195#discussion_r680811652



##########
File path: flink/flink1.10-shims/src/main/java/org/apache/zeppelin/flink/Flink110Shims.java
##########
@@ -337,4 +344,27 @@ public Map extractTableConfigOptions() {
     }
     return fields;
   }
+
+  public boolean isTimeIndicatorType(Object type) {
+    return FlinkTypeFactory.isTimeIndicatorType((TypeInformation<?>) type);
+  }
+
+  @Override
+  public Object lookupExecutor(ClassLoader classLoader, Object environmentSettings, Object sEnv) {

Review comment:
       flink-shims don't have flink dependencies, so can not use these flink classes. Only sub-modules has flink dependency. This do cause code duplication, but I don't have better way to avoid that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org