You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rampart-dev@ws.apache.org by "Mike Rheinheimer (JIRA)" <ji...@apache.org> on 2010/04/07 18:51:33 UTC
[jira] Created: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
-------------------------------------------------------------------------------------------
Key: AXIS2-4673
URL: https://issues.apache.org/jira/browse/AXIS2-4673
Project: Axis2
Issue Type: Bug
Components: kernel
Reporter: Mike Rheinheimer
Assignee: Mike Rheinheimer
Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
{code}
Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
{code}
I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated AXIS2-4673:
------------------------------------
Attachment: AXIS2-4673.patch
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated AXIS2-4673:
------------------------------------
Description:
Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
I'll attach a proposed patch with fix.
was:
Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
{code}
Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
{code}
I'll attach a proposed patch with fix.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854687#action_12854687 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
Ah, right... so what's the better way? I'd rather not do read() and reset() just to check it. That could have the side effect of resetting further back than the current marker.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated AXIS2-4673:
------------------------------------
Description:
Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
I'll attach a proposed patch with fix.
was:
Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
{code}
Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
{code}
I'll attach a proposed patch with fix.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated AXIS2-4673:
------------------------------------
Attachment: AXIS2-4673.patch
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854662#action_12854662 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
The condition inStream.available() > 0 does NOT check for an empty input stream! Please have a look at the relevant Javadoc.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Resolved: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved AXIS2-4673.
------------------------------------
Resolution: Won't Fix
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854716#action_12854716 ]
Rich Scheuerle commented on AXIS2-4673:
---------------------------------------
If you do proceed with the checking for an empty stream, then I agree that you need to do more than just check isAvailable.
I also think that the Sandesha should be changed if possible. An empty SOAPEnvelope is much different than no message.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854945#action_12854945 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
All fair points. Agree that if Sandesha is the only detector and reporter of this particular problem, it's probably best to pursue resolution in Sandesha. I've pointed David Parsons to this Jira, so he's read up on the conversation. Discussion of resolution with Sandesha will continue.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854716#action_12854716 ]
Rich Scheuerle commented on AXIS2-4673:
---------------------------------------
If you do proceed with the checking for an empty stream, then I agree that you need to do more than just check isAvailable.
I also think that the Sandesha should be changed if possible. An empty SOAPEnvelope is much different than no message.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854883#action_12854883 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
I agree with Rich. Since TransportUtils.createSOAPEnvelope is used by most of the transports and an empty payload is invalid in that context (unless the message builder decides otherwise), we should not introduce hacks to work around specific problems in Sandesha.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854693#action_12854693 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
My question is actually: why do you want to change the behavior of TransportUtils.createSOAPEnvelope? What is the actual problem with it?
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854703#action_12854703 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
The problem originated from Sandesha. Cut/paste from a very old note: "The problem is that if we don't get a response on the back channel of a sync 2-way message we don't know this so we start to parse the message which causes this exception." "The best solution is for Sandesha to not call the createSOAPMessage if there is nothing to create, but at the moment I don't think there is any way to tell."
David Parsons might be the better person to ask if we really want to dig into it.
Meanwhile, I can put together a better patch for the cases where .available() returns 0. I figure I'd have to check if mark() is supported, then read ahead and reset, or when mark() is not supported, read the whole thing into a BAIS to be passed along. Your thoughts?
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854703#action_12854703 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
The problem originated from Sandesha. Cut/paste from a very old note: "The problem is that if we don't get a response on the back channel of a sync 2-way message we don't know this so we start to parse the message which causes this exception." "The best solution is for Sandesha to not call the createSOAPMessage if there is nothing to create, but at the moment I don't think there is any way to tell."
David Parsons might be the better person to ask if we really want to dig into it.
Meanwhile, I can put together a better patch for the cases where .available() returns 0. I figure I'd have to check if mark() is supported, then read ahead and reset, or when mark() is not supported, read the whole thing into a BAIS to be passed along. Your thoughts?
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854716#action_12854716 ]
Rich Scheuerle commented on AXIS2-4673:
---------------------------------------
If you do proceed with the checking for an empty stream, then I agree that you need to do more than just check isAvailable.
I also think that the Sandesha should be changed if possible. An empty SOAPEnvelope is much different than no message.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854693#action_12854693 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
My question is actually: why do you want to change the behavior of TransportUtils.createSOAPEnvelope? What is the actual problem with it?
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Resolved: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved AXIS2-4673.
------------------------------------
Resolution: Won't Fix
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854662#action_12854662 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
The condition inStream.available() > 0 does NOT check for an empty input stream! Please have a look at the relevant Javadoc.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854883#action_12854883 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
I agree with Rich. Since TransportUtils.createSOAPEnvelope is used by most of the transports and an empty payload is invalid in that context (unless the message builder decides otherwise), we should not introduce hacks to work around specific problems in Sandesha.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated AXIS2-4673:
------------------------------------
Attachment: AXIS2-4673.patch
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854687#action_12854687 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
Ah, right... so what's the better way? I'd rather not do read() and reset() just to check it. That could have the side effect of resetting further back than the current marker.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854662#action_12854662 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
The condition inStream.available() > 0 does NOT check for an empty input stream! Please have a look at the relevant Javadoc.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854693#action_12854693 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
My question is actually: why do you want to change the behavior of TransportUtils.createSOAPEnvelope? What is the actual problem with it?
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854716#action_12854716 ]
Rich Scheuerle commented on AXIS2-4673:
---------------------------------------
If you do proceed with the checking for an empty stream, then I agree that you need to do more than just check isAvailable.
I also think that the Sandesha should be changed if possible. An empty SOAPEnvelope is much different than no message.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854693#action_12854693 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
My question is actually: why do you want to change the behavior of TransportUtils.createSOAPEnvelope? What is the actual problem with it?
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854716#action_12854716 ]
Rich Scheuerle commented on AXIS2-4673:
---------------------------------------
If you do proceed with the checking for an empty stream, then I agree that you need to do more than just check isAvailable.
I also think that the Sandesha should be changed if possible. An empty SOAPEnvelope is much different than no message.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated AXIS2-4673:
------------------------------------
Attachment: AXIS2-4673.patch
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854703#action_12854703 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
The problem originated from Sandesha. Cut/paste from a very old note: "The problem is that if we don't get a response on the back channel of a sync 2-way message we don't know this so we start to parse the message which causes this exception." "The best solution is for Sandesha to not call the createSOAPMessage if there is nothing to create, but at the moment I don't think there is any way to tell."
David Parsons might be the better person to ask if we really want to dig into it.
Meanwhile, I can put together a better patch for the cases where .available() returns 0. I figure I'd have to check if mark() is supported, then read ahead and reset, or when mark() is not supported, read the whole thing into a BAIS to be passed along. Your thoughts?
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Resolved: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved AXIS2-4673.
------------------------------------
Resolution: Won't Fix
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Resolved: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved AXIS2-4673.
------------------------------------
Resolution: Won't Fix
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated AXIS2-4673:
------------------------------------
Description:
Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
I'll attach a proposed patch with fix.
was:
Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
{code}
Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
{code}
I'll attach a proposed patch with fix.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Resolved: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved AXIS2-4673.
------------------------------------
Resolution: Won't Fix
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854693#action_12854693 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
My question is actually: why do you want to change the behavior of TransportUtils.createSOAPEnvelope? What is the actual problem with it?
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854687#action_12854687 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
Ah, right... so what's the better way? I'd rather not do read() and reset() just to check it. That could have the side effect of resetting further back than the current marker.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854883#action_12854883 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
I agree with Rich. Since TransportUtils.createSOAPEnvelope is used by most of the transports and an empty payload is invalid in that context (unless the message builder decides otherwise), we should not introduce hacks to work around specific problems in Sandesha.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated AXIS2-4673:
------------------------------------
Description:
Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
I'll attach a proposed patch with fix.
was:
Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
{code}
Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
{code}
I'll attach a proposed patch with fix.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854945#action_12854945 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
All fair points. Agree that if Sandesha is the only detector and reporter of this particular problem, it's probably best to pursue resolution in Sandesha. I've pointed David Parsons to this Jira, so he's read up on the conversation. Discussion of resolution with Sandesha will continue.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated AXIS2-4673:
------------------------------------
Attachment: AXIS2-4673.patch
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854662#action_12854662 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
The condition inStream.available() > 0 does NOT check for an empty input stream! Please have a look at the relevant Javadoc.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854883#action_12854883 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
I agree with Rich. Since TransportUtils.createSOAPEnvelope is used by most of the transports and an empty payload is invalid in that context (unless the message builder decides otherwise), we should not introduce hacks to work around specific problems in Sandesha.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854883#action_12854883 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
I agree with Rich. Since TransportUtils.createSOAPEnvelope is used by most of the transports and an empty payload is invalid in that context (unless the message builder decides otherwise), we should not introduce hacks to work around specific problems in Sandesha.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854703#action_12854703 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
The problem originated from Sandesha. Cut/paste from a very old note: "The problem is that if we don't get a response on the back channel of a sync 2-way message we don't know this so we start to parse the message which causes this exception." "The best solution is for Sandesha to not call the createSOAPMessage if there is nothing to create, but at the moment I don't think there is any way to tell."
David Parsons might be the better person to ask if we really want to dig into it.
Meanwhile, I can put together a better patch for the cases where .available() returns 0. I figure I'd have to check if mark() is supported, then read ahead and reset, or when mark() is not supported, read the whole thing into a BAIS to be passed along. Your thoughts?
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854687#action_12854687 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
Ah, right... so what's the better way? I'd rather not do read() and reset() just to check it. That could have the side effect of resetting further back than the current marker.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854945#action_12854945 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
All fair points. Agree that if Sandesha is the only detector and reporter of this particular problem, it's probably best to pursue resolution in Sandesha. I've pointed David Parsons to this Jira, so he's read up on the conversation. Discussion of resolution with Sandesha will continue.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854945#action_12854945 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
All fair points. Agree that if Sandesha is the only detector and reporter of this particular problem, it's probably best to pursue resolution in Sandesha. I've pointed David Parsons to this Jira, so he's read up on the conversation. Discussion of resolution with Sandesha will continue.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854945#action_12854945 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
All fair points. Agree that if Sandesha is the only detector and reporter of this particular problem, it's probably best to pursue resolution in Sandesha. I've pointed David Parsons to this Jira, so he's read up on the conversation. Discussion of resolution with Sandesha will continue.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854687#action_12854687 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
Ah, right... so what's the better way? I'd rather not do read() and reset() just to check it. That could have the side effect of resetting further back than the current marker.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854703#action_12854703 ]
Mike Rheinheimer commented on AXIS2-4673:
-----------------------------------------
The problem originated from Sandesha. Cut/paste from a very old note: "The problem is that if we don't get a response on the back channel of a sync 2-way message we don't know this so we start to parse the message which causes this exception." "The best solution is for Sandesha to not call the createSOAPMessage if there is nothing to create, but at the moment I don't think there is any way to tell."
David Parsons might be the better person to ask if we really want to dig into it.
Meanwhile, I can put together a better patch for the cases where .available() returns 0. I figure I'd have to check if mark() is supported, then read ahead and reset, or when mark() is not supported, read the whole thing into a BAIS to be passed along. Your thoughts?
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Updated: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated AXIS2-4673:
------------------------------------
Description:
Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
I'll attach a proposed patch with fix.
was:
Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
{code}
Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
{code}
I'll attach a proposed patch with fix.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org
[jira] Commented: (AXIS2-4673) kernel
TransportUtils.createSOAPEnvelope should return empty envelope for empty
InputStream
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854662#action_12854662 ]
Andreas Veithen commented on AXIS2-4673:
----------------------------------------
The condition inStream.available() > 0 does NOT check for an empty input stream! Please have a look at the relevant Javadoc.
> kernel TransportUtils.createSOAPEnvelope should return empty envelope for empty InputStream
> -------------------------------------------------------------------------------------------
>
> Key: AXIS2-4673
> URL: https://issues.apache.org/jira/browse/AXIS2-4673
> Project: Axis2
> Issue Type: Bug
> Components: kernel
> Reporter: Mike Rheinheimer
> Assignee: Mike Rheinheimer
> Attachments: AXIS2-4673.patch
>
>
> Currently, the org.apache.axis2.transport.TransportUtils.createSOAPMessage correctly throws an exception for a null InputStream, but passes an empty InputStream down to the parser, which may throw an exception resulting in an exception stack similar to:
> Throwable occurred: org.apache.axiom.om.OMException: javax.xml.stream.XMLStreamException: The root element is required in a well-formed document.
> at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:252)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.getSOAPEnvelope(StAXSOAPModelBuilder.java:156)
> at org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder.<init>(StAXSOAPModelBuilder.java:105)
> at org.apache.axis2.builder.BuilderUtil.getSOAPBuilder(BuilderUtil.java:677)
> at org.apache.axis2.transport.TransportUtils.createDocumentElement(TransportUtils.java:209)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:139)
> at org.apache.axis2.transport.TransportUtils.createSOAPMessage(TransportUtils.java:102)
> at org.apache.sandesha2.workers.SenderWorker.checkForSyncResponses(SenderWorker.java:610)
> I'll attach a proposed patch with fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org