You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Joe Orton <jo...@redhat.com> on 2004/10/01 13:46:35 UTC
Re: [PATCH] Re: t/SMOKE points the finger at filter/out_bbs_filebucket.t
I'm not sure if you guys noticed but since I changed ap_save_brigade's
handling of ENOTIMPL setasides on HEAD (motivated by a similar issue)
there are now several tests always failing:
t/filter/out_bbs_basic.t 255 65280 ?? ?? % ??
t/filter/out_bbs_ctx.t 1 1 100.00% 1
t/filter/out_bbs_filebucket.t 10 2 20.00% 1-2
these fail because ap_save_brigade now fails immediately if ->setaside()
is ENOTIMPL and ->read() does not morph the bucket. core_output_filter
rudely ignores the ap_save_brigade return value and so silently the
entire response gets dropped on the floor.
I think I'll have to change ap_save_brigade again to fix this in the
short term (since I want that fix in 2.0 too), but it would definitely
be good to have the mod_perl SV bucket type implement setaside properly
for the long term.
joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: t/SMOKE points the finger at filter/out_bbs_filebucket.t
Posted by Stas Bekman <st...@stason.org>.
Joe Schaefer wrote:
> Joe Orton <jo...@redhat.com> writes:
>
>
>>I'm not sure if you guys noticed but since I changed ap_save_brigade's
>>handling of ENOTIMPL setasides on HEAD (motivated by a similar issue)
>>there are now several tests always failing:
>>
>>t/filter/out_bbs_basic.t 255 65280 ?? ?? % ??
>>t/filter/out_bbs_ctx.t 1 1 100.00% 1
>>t/filter/out_bbs_filebucket.t 10 2 20.00% 1-2
>>
>>these fail because ap_save_brigade now fails immediately if ->setaside()
>>is ENOTIMPL and ->read() does not morph the bucket. core_output_filter
>>rudely ignores the ap_save_brigade return value and so silently the
>>entire response gets dropped on the floor.
>
>
> Yes, I'm aware, and my recent (large) bucket brigade patch takes
> care of this, because it implements a proper setaside function.
> These tests should pass if you apply the patch.
Perfect timing, joe&&joe++ :)
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Re: t/SMOKE points the finger at filter/out_bbs_filebucket.t
Posted by Joe Schaefer <jo...@sunstarsys.com>.
Joe Orton <jo...@redhat.com> writes:
> I'm not sure if you guys noticed but since I changed ap_save_brigade's
> handling of ENOTIMPL setasides on HEAD (motivated by a similar issue)
> there are now several tests always failing:
>
> t/filter/out_bbs_basic.t 255 65280 ?? ?? % ??
> t/filter/out_bbs_ctx.t 1 1 100.00% 1
> t/filter/out_bbs_filebucket.t 10 2 20.00% 1-2
>
> these fail because ap_save_brigade now fails immediately if ->setaside()
> is ENOTIMPL and ->read() does not morph the bucket. core_output_filter
> rudely ignores the ap_save_brigade return value and so silently the
> entire response gets dropped on the floor.
Yes, I'm aware, and my recent (large) bucket brigade patch takes
care of this, because it implements a proper setaside function.
These tests should pass if you apply the patch.
--
Joe Schaefer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org