You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Paul Stanton (JIRA)" <ji...@apache.org> on 2011/01/09 21:08:45 UTC
[jira] Created: (TAP5-1408) datefield popup does not have option to
cancel
datefield popup does not have option to cancel
----------------------------------------------
Key: TAP5-1408
URL: https://issues.apache.org/jira/browse/TAP5-1408
Project: Tapestry 5
Issue Type: Bug
Affects Versions: 5.2.4
Reporter: Paul Stanton
using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Resolved] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler resolved TAP5-1408.
----------------------------------
Resolution: Fixed
Fixed with proper test (which /does/ fail without the fix in place!)
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Paul Stanton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979536#action_12979536 ]
Paul Stanton commented on TAP5-1408:
------------------------------------
my patch for TAP5-1409 partially resolves this as it allows the user to close the popup by selecting the current value. i think this, combined with changing the calendar icon (that launches the popup) to something that describes a close action (like an 'x') would completely resolve this issue.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Benny Law (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979415#action_12979415 ]
Benny Law commented on TAP5-1408:
---------------------------------
Some of the users of my app are not very experienced with GUIs, and if we are having difficulty figuring out how to cancel a calendar popup, I'm sure it will be even harder for them. I still think the most intuitive way to cancel the popup is to click outside. That's what most users would try first. I don't think it is necessary to clutter the UI with another icon.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072133#comment-13072133 ]
Hudson commented on TAP5-1408:
------------------------------
Integrated in tapestry-trunk-freestyle #440 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/440/])
TAP5-1408: datefield - cannot select same day in different month
TAP5-1409: datefield popup does not have option to cancel
robertdzeigler : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1151673
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/DateFieldDemo.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/datepicker_106/js/datepicker.js
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096174#comment-13096174 ]
Hudson commented on TAP5-1408:
------------------------------
Integrated in tapestry-trunk-freestyle #502 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/502/])
TAP5-1408: datefield popup does not have option to cancel
Resolve issue with original fix where selecting a month from the month dropdown would close the datepicker. Thanks to bkopelove for tracking down the issue and providing a fix.
robertdzeigler : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164595
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/datepicker_106/js/datepicker.js
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1408) datefield popup does not have option to
cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler closed TAP5-1408.
--------------------------------
Resolution: Fixed
Fixed, with test.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1408) datefield popup does not have option to
cancel
Posted by "Robert Zeigler (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler closed TAP5-1408.
--------------------------------
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1408) datefield popup does not have option to
cancel
Posted by "Robert Zeigler (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler closed TAP5-1408.
--------------------------------
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler reopened TAP5-1408:
----------------------------------
>From 1409:
"This fix is great but it introduced a different bug. When one clicks on the month name at the top of the calendar, a popup list of surrounding months is shown. Upon clicking one of these months, the calendar disappears because the javascript thinks that you have clicked "outside" the calendar and exits.
I identified a simple fix to not exit when a popup month is selected:
---change:
331 if (parent.className == 'datePicker') {
---to:
331 if (parent.className == 'datePicker' || parent.className == 'labelPopup') { "
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1408) datefield popup does not have option to
cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler closed TAP5-1408.
--------------------------------
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Benny Law (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979411#action_12979411 ]
Benny Law commented on TAP5-1408:
---------------------------------
The popup can be cancelled by clicking the icon again. However, it would be nice if the popup could be cancelled by clicking outside it or pressing Esc which is normal behaviour for most dropdowns and popups.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Resolved] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler resolved TAP5-1408.
----------------------------------
Resolution: Fixed
Fix Version/s: 5.3
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Benny Law (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979411#action_12979411 ]
Benny Law commented on TAP5-1408:
---------------------------------
The popup can be cancelled by clicking the icon again. However, it would be nice if the popup could be cancelled by clicking outside it or pressing Esc which is normal behaviour for most dropdowns and popups.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131392#comment-13131392 ]
Hudson commented on TAP5-1408:
------------------------------
Integrated in tapestry-trunk-freestyle #594 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/594/])
TAP5-1408: datefield popup does not have option to cancel. Fix and properly
test for issue where selecting a month from the "month menu" would prematurely
close the datepicker. Previous version of the test was checking the visibility
too quickly so the picker was still visible for the test even though it would
disappear a few milliseconds later.
robertdzeigler : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186612
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/datepicker_106/js/datepicker.js
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1408) datefield popup does not have option to
cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler closed TAP5-1408.
--------------------------------
Resolution: Fixed
Fixed, with test.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler reassigned TAP5-1408:
------------------------------------
Assignee: Robert Zeigler
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler resolved TAP5-1408.
----------------------------------
Resolution: Fixed
Fix Version/s: 5.3
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler reopened TAP5-1408:
----------------------------------
The bug with the datepicker closing when selecting a month from the drop down is still present; the test for it was checking the visibility too quickly, so the picker was still visible for the test, but would not be visible a few milliseconds later.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072133#comment-13072133 ]
Hudson commented on TAP5-1408:
------------------------------
Integrated in tapestry-trunk-freestyle #440 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/440/])
TAP5-1408: datefield - cannot select same day in different month
TAP5-1409: datefield popup does not have option to cancel
robertdzeigler : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1151673
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/DateFieldDemo.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/datepicker_106/js/datepicker.js
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Benny Law (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979415#action_12979415 ]
Benny Law commented on TAP5-1408:
---------------------------------
Some of the users of my app are not very experienced with GUIs, and if we are having difficulty figuring out how to cancel a calendar popup, I'm sure it will be even harder for them. I still think the most intuitive way to cancel the popup is to click outside. That's what most users would try first. I don't think it is necessary to clutter the UI with another icon.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Paul Stanton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979412#action_12979412 ]
Paul Stanton commented on TAP5-1408:
------------------------------------
ah, didn't notice that .. i tried clicking within the textfield its self, clicking outside, clicking the existing value cell ...
perhaps a close icon would be most intuitive for dumb users like myself.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131392#comment-13131392 ]
Hudson commented on TAP5-1408:
------------------------------
Integrated in tapestry-trunk-freestyle #594 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/594/])
TAP5-1408: datefield popup does not have option to cancel. Fix and properly
test for issue where selecting a month from the "month menu" would prematurely
close the datepicker. Previous version of the test was checking the visibility
too quickly so the picker was still visible for the test even though it would
disappear a few milliseconds later.
robertdzeigler : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186612
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/datepicker_106/js/datepicker.js
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Paul Stanton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979412#action_12979412 ]
Paul Stanton commented on TAP5-1408:
------------------------------------
ah, didn't notice that .. i tried clicking within the textfield its self, clicking outside, clicking the existing value cell ...
perhaps a close icon would be most intuitive for dumb users like myself.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Reopened] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler reopened TAP5-1408:
----------------------------------
>From 1409:
"This fix is great but it introduced a different bug. When one clicks on the month name at the top of the calendar, a popup list of surrounding months is shown. Upon clicking one of these months, the calendar disappears because the javascript thinks that you have clicked "outside" the calendar and exits.
I identified a simple fix to not exit when a popup month is selected:
---change:
331 if (parent.className == 'datePicker') {
---to:
331 if (parent.className == 'datePicker' || parent.className == 'labelPopup') { "
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler reopened TAP5-1408:
----------------------------------
The bug with the datepicker closing when selecting a month from the drop down is still present; the test for it was checking the visibility too quickly, so the picker was still visible for the test, but would not be visible a few milliseconds later.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Lenny Primak (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131306#comment-13131306 ]
Lenny Primak commented on TAP5-1408:
------------------------------------
I think this is broken again...
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072107#comment-13072107 ]
Robert Zeigler commented on TAP5-1408:
--------------------------------------
Went with the ability to click anywhere outside the calendar closes the calendar. No new icon.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Paul Stanton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979536#action_12979536 ]
Paul Stanton commented on TAP5-1408:
------------------------------------
my patch for TAP5-1409 partially resolves this as it allows the user to close the popup by selecting the current value. i think this, combined with changing the calendar icon (that launches the popup) to something that describes a close action (like an 'x') would completely resolve this issue.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096174#comment-13096174 ]
Hudson commented on TAP5-1408:
------------------------------
Integrated in tapestry-trunk-freestyle #502 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/502/])
TAP5-1408: datefield popup does not have option to cancel
Resolve issue with original fix where selecting a month from the month dropdown would close the datepicker. Thanks to bkopelove for tracking down the issue and providing a fix.
robertdzeigler : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164595
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/datepicker_106/js/datepicker.js
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Lenny Primak (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131306#comment-13131306 ]
Lenny Primak commented on TAP5-1408:
------------------------------------
I think this is broken again...
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler reassigned TAP5-1408:
------------------------------------
Assignee: Robert Zeigler
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072107#comment-13072107 ]
Robert Zeigler commented on TAP5-1408:
--------------------------------------
Went with the ability to click anywhere outside the calendar closes the calendar. No new icon.
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1408) datefield popup does not have option
to cancel
Posted by "Robert Zeigler (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler resolved TAP5-1408.
----------------------------------
Resolution: Fixed
Fixed with proper test (which /does/ fail without the fix in place!)
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1408) datefield popup does not have option to
cancel
Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler closed TAP5-1408.
--------------------------------
> datefield popup does not have option to cancel
> ----------------------------------------------
>
> Key: TAP5-1408
> URL: https://issues.apache.org/jira/browse/TAP5-1408
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.2.4
> Reporter: Paul Stanton
> Assignee: Robert Zeigler
> Fix For: 5.3
>
>
> using the datefield component, if a user changes their mind there seems to be no way for them to close the popup without changing the value in some way.
> once the icon has been clicked, there's no option to close the popup explicitly and selecting the current value is disabled so the user has to select another date to close the popup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira