[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4768: Update kamon-core, instrumentations and reporters to 2.0.x.

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #4768: Update kamon-core, instrumentations and reporters to 2.0.x.
URL: https://github.com/apache/openwhisk/pull/4768#discussion_r365496826
 
 

 ##########
 File path: common/scala/src/main/resources/application.conf
 ##########
 @@ -36,6 +36,27 @@ akka.http {
 
 #kamon related configuration
 kamon {
+    modules {
+        # Only statsd is enabled by default.
+        statsd-reporter {
+            enabled = true
+        }
+        datadog-agent {
+            enabled = false
+        }
+        datadog-trace-agent {
+            enabled = false
+        }
+        # This should never be set to true as we register Prometheus reporters manually and surface them via akka-http.
+        prometheus-reporter {
+            enabled = false
+        }
+
+        host-metrics {
+            enabled = no
 
 Review comment:
   Nit: Just to keep it consistent better to use `false`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services