[jira] [Commented] (MYRIAD-236) YarnNodeCapacityManager--enable reset in setNodeCapacity or make setNodeCapacity protected/private

["John Yost (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MYRIAD-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407772#comment-15407772 ] 

John Yost commented on MYRIAD-236:
----------------------------------

Investigating this further, the incrementNodeCapacity and decrementNodeCapacity are not invoked anywhere in the codebase outside of my JUnit tests. The setNodeCapacity methos is only invoked in the NMHeartBeatHandler.handleStatusUpdate method which is only visible for testing. Consequently, I recommend closing this ticket.

> YarnNodeCapacityManager--enable reset in setNodeCapacity or make setNodeCapacity protected/private
> --------------------------------------------------------------------------------------------------
>
>                 Key: MYRIAD-236
>                 URL: https://issues.apache.org/jira/browse/MYRIAD-236
>             Project: Myriad
>          Issue Type: Bug
>            Reporter: John Yost
>
> Currently the setNodeCapacity method does not enable setting of the node capacity to a specific value--only incrementing or decrementing. Moreover, the incrementNodeCapacity and decrementNodeCapacity methods both delegate to setNodeCapacity.  I recommend one of two options: (1) adding the capability to set the node capacity to a specific value and enable this capability within the GUI or (2) making setNodeCapacity protected or private.
> If there are use cases for option (1) where it would be good to set to a specific capacity--irrespective of the current capacity--I recommend that one.
> This issue arose during my work on MYRIAD-229, so I can fix it within that branch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)