You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by leifurhauks <gi...@git.apache.org> on 2016/06/22 14:53:01 UTC
[GitHub] tinkerpop pull request #344: gremlin_python: generate/build/deps before test...
GitHub user leifurhauks opened a pull request:
https://github.com/apache/tinkerpop/pull/344
gremlin_python: generate/build/deps before tests
Code generation is triggered by Maven before tests are run; dependencies
(currently aenum, requests) are installed, and the generated package is built
into ${project.build.testOutputDirectory}/Lib, which is added to the
classpath for the tests via the python.home property. Jython tests
import the gremlin_python package instead of importing its modules
directly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/leifurhauks/incubator-tinkerpop python_test_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/344.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #344
----
commit 252e358d7e0acf519e384da590050c6c55369a29
Author: Leifur Halldor Asgeirsson <la...@zerofail.com>
Date: 2016-06-22T13:34:41Z
gremlin_python: generate/build/deps before tests
Code generation is triggered by Maven before tests are run; dependencies
(currently aenum, requests) are installed, and the generated package is built
into ${project.build.testOutputDirectory}/Lib, which is added to the
classpath for the tests via the python.home property. Jython tests
import the gremlin_python package instead of importing its modules
directly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #344: gremlin_python: generate/build/deps before tests
Posted by leifurhauks <gi...@git.apache.org>.
Github user leifurhauks commented on the issue:
https://github.com/apache/tinkerpop/pull/344
Also, the generated `__version__.py` file fails the rat check. I think it needs to be either
a) generated with the license boilerplate
b) excluded from the rat check, or
c) included in the clean configuration.
Please advise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #344: gremlin_python: generate/build/deps before tests
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/344
Can you add the license boilerplate?
BTW: Just pulled your patch and building locally now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #344: gremlin_python: generate/build/deps before tests
Posted by leifurhauks <gi...@git.apache.org>.
Github user leifurhauks commented on the issue:
https://github.com/apache/tinkerpop/pull/344
I think this should fix the CI test failures.
On the subject of the python dependencies (aenum and requests), should they be bundled in the jar? aenum has a 3-clause BSD [license](https://bitbucket.org/stoneleaf/aenum/src/c9dc3b8fc3e3755a919ba4357ab9ed9b22131af1/aenum/LICENSE?at=default&fileviewer=file-view-default), and requests uses the ASL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #344: gremlin_python: generate/build/deps before test...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/344
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---