You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/14 19:45:40 UTC
[GitHub] [spark] sarutak opened a new pull request #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
sarutak opened a new pull request #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This change explicitly set locale of timeline view to 'en' to be the same appearance as before upgrading vis-timeline.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We upgraded vis-timeline in #28192 and upgraded version is different from before in the notation of dates.
The notation seems to be dependent on locale. The following is appearance in my Japanese environment.
<img width="557" alt="locale-changed" src="https://user-images.githubusercontent.com/4736016/79265314-de886700-7ed0-11ea-8641-fa76b993c0d9.png">
Although the notation is in Japanese, the default format is a little bit unnatural (e.g. 4月9日 05:39 is natural rather than 9 四月 05:39).
I found we can get the same appearance as before by explicitly set locale to 'en'.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
I visited JobsPage, JobPage and StagePage and confirm that timeline view shows dates with 'en' locale.
<img width="735" alt="fix-date-appearance" src="https://user-images.githubusercontent.com/4736016/79267107-8bfc7a00-7ed3-11ea-8a25-f6681d04a83c.png">
NOTE: #28192 will be backported to branch-2.4 and branch-3.0 so this PR should be follow #28214 and #28213 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-613720906
**[Test build #121291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121291/testReport)** for PR 28218 at commit [`20bfd4d`](https://github.com/apache/spark/commit/20bfd4d251d94a577fb09f9047d914f6d6a5bf39).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-613721563
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121291/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-613645717
**[Test build #121291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121291/testReport)** for PR 28218 at commit [`20bfd4d`](https://github.com/apache/spark/commit/20bfd4d251d94a577fb09f9047d914f6d6a5bf39).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-613721563
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121291/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-613646167
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-613646181
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25976/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
sarutak commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-614781923
Thanks @srowen , @HyukjinKwon and @gatorsmile !
Merging this into `master`, `branch-3.0` and `branch-2.4`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-613721554
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-613646181
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25976/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-614770468
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-614425248
I'm OK with it. I would have thought localized display is a little better, but the whole UI is clearly written for locale=en anyway. Maybe it's more consistent to standardize that rather than have random bits localized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-613721554
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-614853999
Hi, @sarutak .
When you use `dev/merge_spark_pr.py` next time, could you accept `Would you like to use the modified body?` direction, please? That helps us clean up `PULL_REQUEST_TEMPLATE` from the commit log. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
sarutak commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-614704413
@srowen
Yeah, At first, I thought it's better to make locale customizable but any other parts in the UI i s not like so.
So, I explicitly set 'en' for the consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-613645717
**[Test build #121291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121291/testReport)** for PR 28218 at commit [`20bfd4d`](https://github.com/apache/spark/commit/20bfd4d251d94a577fb09f9047d914f6d6a5bf39).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
sarutak commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-614860973
Yeah, I noticed that when I confirmed the log message. Thanks for the notice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-613646167
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-614618978
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on issue #28218:
[SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on issue #28218: [SPARK-31420][WEBUI][FOLLOWUP] Make locale of timeline-view 'en'
URL: https://github.com/apache/spark/pull/28218#issuecomment-614704413
@srowen
Yeah, At first, I thought it's better to make locale customizable but any other parts in the UI i s not like so.
So, I explicitly set locale to 'en' for the consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org