You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/11/22 02:26:02 UTC
[GitHub] [incubator-inlong] inter12 commented on a change in pull request #1818: [INLONG-1753][Feature][InLong-Manager] Add basic management APIs for Pulsar
inter12 commented on a change in pull request #1818:
URL: https://github.com/apache/incubator-inlong/pull/1818#discussion_r753905321
##########
File path: docker/docker-compose/sql/apache_inlong_manager.sql
##########
@@ -106,6 +106,28 @@ CREATE TABLE `business`
AUTO_INCREMENT = 16
DEFAULT CHARSET = utf8mb4 COMMENT ='Business table';
+-- ----------------------------
+-- Table structure for business_pulsar
+-- ----------------------------
+DROP TABLE IF EXISTS `business_pulsar`;
+CREATE TABLE `business_pulsar`
+(
+ `id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'Incremental primary key',
+ `inlong_group_id` varchar(128) NOT NULL COMMENT 'Business group id, filled in by the user, undeleted ones cannot be repeated',
+ `ensemble` int(3) DEFAULT NULL COMMENT 'The writable nodes number of leader',
+ `write_quorum` int(3) DEFAULT NULL COMMENT 'The copies number of leader',
+ `ack_quorum` int(3) DEFAULT NULL COMMENT 'The number of requested acks',
+ `retention_time` int(11) DEFAULT NULL COMMENT 'Message storage time',
+ `retention_time_unit` char(20) DEFAULT NULL COMMENT 'The unit of the message storage time',
+ `ttl` int(11) DEFAULT NULL COMMENT 'Message time-to-live duration',
+ `ttl_unit` varchar(20) DEFAULT NULL COMMENT 'The unit of time-to-live duration',
+ `retention_size` int(11) DEFAULT NULL COMMENT 'Message size',
+ `retention_size_unit` varchar(20) DEFAULT NULL COMMENT 'The unit of message size',
+ `is_deleted` tinyint(1) DEFAULT '0' COMMENT 'Whether to delete, 0: not deleted, 1: deleted',
Review comment:
any table should have create_time and modify_time field。
##########
File path: docker/docker-compose/sql/apache_inlong_manager.sql
##########
@@ -106,6 +106,28 @@ CREATE TABLE `business`
AUTO_INCREMENT = 16
DEFAULT CHARSET = utf8mb4 COMMENT ='Business table';
+-- ----------------------------
+-- Table structure for business_pulsar
+-- ----------------------------
+DROP TABLE IF EXISTS `business_pulsar`;
+CREATE TABLE `business_pulsar`
+(
+ `id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'Incremental primary key',
+ `inlong_group_id` varchar(128) NOT NULL COMMENT 'Business group id, filled in by the user, undeleted ones cannot be repeated',
+ `ensemble` int(3) DEFAULT NULL COMMENT 'The writable nodes number of leader',
+ `write_quorum` int(3) DEFAULT NULL COMMENT 'The copies number of leader',
Review comment:
default value should not be null . it Unfriendly mysql index
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/DataStreamServiceImpl.java
##########
@@ -575,6 +576,16 @@ public int selectCountByGroupId(String groupId) {
return count;
}
+ @Override
+ public List<DataStreamTopicVO> getTopicList(String groupId) {
+ LOGGER.debug("begin bo get topic list by group id={}", groupId);
+ Preconditions.checkNotNull(groupId, BizConstant.GROUP_ID_IS_EMPTY);
+
+ List<DataStreamTopicVO> topicList = streamMapper.selectTopicList(groupId);
+ LOGGER.debug("success to get topic list");
Review comment:
add more request info in debug is better。eg. groupid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org