You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@synapse.apache.org by hi...@apache.org on 2010/09/23 11:38:59 UTC
svn commit: r1000381 - in
/synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons:
evaluators/Parser.java executors/MultiPriorityBlockingQueue.java
util/TemporaryData.java
Author: hiranya
Date: Thu Sep 23 09:38:58 2010
New Revision: 1000381
URL: http://svn.apache.org/viewvc?rev=1000381&view=rev
Log:
Refactoring
Modified:
synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java
synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/executors/MultiPriorityBlockingQueue.java
synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/util/TemporaryData.java
Modified: synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java
URL: http://svn.apache.org/viewvc/synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java?rev=1000381&r1=1000380&r2=1000381&view=diff
==============================================================================
--- synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java (original)
+++ synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java Thu Sep 23 09:38:58 2010
@@ -97,14 +97,6 @@ public class Parser {
}
/**
- * Set the Conditions
- * @param conditions <code>array</code> of conditions
- */
- public void setConditions(Condition[] conditions) {
- this.conditions = conditions;
- }
-
- /**
* Build the parser from a given XML
*
* @param conditions set of conditions
Modified: synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/executors/MultiPriorityBlockingQueue.java
URL: http://svn.apache.org/viewvc/synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/executors/MultiPriorityBlockingQueue.java?rev=1000381&r1=1000380&r2=1000381&view=diff
==============================================================================
--- synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/executors/MultiPriorityBlockingQueue.java (original)
+++ synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/executors/MultiPriorityBlockingQueue.java Thu Sep 23 09:38:58 2010
@@ -399,11 +399,11 @@ public class MultiPriorityBlockingQueue<
final ReentrantLock lock = this.lock;
lock.lock();
try {
- String s = "";
+ StringBuffer s = new StringBuffer();
for (InternalQueue<E> internalQueue : queues) {
- s += internalQueue.toString();
+ s.append(internalQueue.toString());
}
- return s;
+ return s.toString();
} finally {
lock.unlock();
}
Modified: synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/util/TemporaryData.java
URL: http://svn.apache.org/viewvc/synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/util/TemporaryData.java?rev=1000381&r1=1000380&r2=1000381&view=diff
==============================================================================
--- synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/util/TemporaryData.java (original)
+++ synapse/branches/2.0/modules/commons/src/main/java/org/apache/synapse/commons/util/TemporaryData.java Thu Sep 23 09:38:58 2010
@@ -1,6 +1,7 @@
package org.apache.synapse.commons.util;
import org.apache.commons.io.IOUtils;
+import org.apache.commons.io.FileUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -355,7 +356,7 @@ public class TemporaryData {
if (log.isDebugEnabled()) {
log.debug("Deleting temporary file " + temporaryFile);
}
- temporaryFile.delete();
+ FileUtils.deleteQuietly(temporaryFile);
}
}
@@ -364,7 +365,7 @@ public class TemporaryData {
protected void finalize() throws Throwable {
if (temporaryFile != null) {
log.warn("Cleaning up unreleased temporary file " + temporaryFile);
- temporaryFile.delete();
+ FileUtils.deleteQuietly(temporaryFile);
}
}
}