You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2017/01/24 12:40:57 UTC
Review Request 55877: Validation errors are not shown if properties
do not exist
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55877/
-----------------------------------------------------------
Review request for Ambari and Denys Buzhor.
Bugs: AMBARI-19691
https://issues.apache.org/jira/browse/AMBARI-19691
Repository: ambari
Description
-------
Say property A, when set to a specific value, needs property B and C. But property B and C do not exist in the config bag. This could be due to them being optional and hence deleted or its after Ambari upgrade and the optional properties B and C are not added.
Now if stack advisor throws validation warnings that B and C must exist and have a valid values those warnings are not shown in the UI.
Fixing this behavior is also critical as we are trying not to add optional properties when Ambari is upgraded to avoid service restarts.
Diffs
-----
ambari-web/app/mixins/common/serverValidator.js 9fb5ae3
ambari-web/test/mixins/common/serverValidator_test.js 943eb57
Diff: https://reviews.apache.org/r/55877/diff/
Testing
-------
30309 passing (22s)
157 pending
Thanks,
Andriy Babiichuk
Re: Review Request 55877: Validation errors are not shown if
properties do not exist
Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55877/#review162799
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Buzhor
On Jan. 24, 2017, 12:40 p.m., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55877/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2017, 12:40 p.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: AMBARI-19691
> https://issues.apache.org/jira/browse/AMBARI-19691
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Say property A, when set to a specific value, needs property B and C. But property B and C do not exist in the config bag. This could be due to them being optional and hence deleted or its after Ambari upgrade and the optional properties B and C are not added.
>
> Now if stack advisor throws validation warnings that B and C must exist and have a valid values those warnings are not shown in the UI.
>
> Fixing this behavior is also critical as we are trying not to add optional properties when Ambari is upgraded to avoid service restarts.
>
>
> Diffs
> -----
>
> ambari-web/app/mixins/common/serverValidator.js 9fb5ae3
> ambari-web/test/mixins/common/serverValidator_test.js 943eb57
>
> Diff: https://reviews.apache.org/r/55877/diff/
>
>
> Testing
> -------
>
> 30309 passing (22s)
> 157 pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>