[jira] [Commented] (WICKET-6203) rework IModel#mapWith

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379852#comment-15379852 ] 

ASF GitHub Bot commented on WICKET-6203:
----------------------------------------

GitHub user noobymatze opened a pull request:

    https://github.com/apache/wicket/pull/174

    WICKET-6203 rework IModel#mapWith

    I implemented the changes proposed in https://issues.apache.org/jira/browse/WICKET-6203.
    
    Please don't hesitate to yell at me, if I did something wrong or something is missing. I tried to conform to the contribution guidelines.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/noobymatze/wicket rework-model-mapWith

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #174
    
----
commit a0c43bb9808c5e6b916e6461b357c3eaa4fa84fc
Author: Matthias Metzger <no...@yahoo.de>
Date:   2016-07-15T18:01:45Z

    WICKET-6203 rework IModel#mapWith

----


> rework IModel#mapWith
> ---------------------
>
>                 Key: WICKET-6203
>                 URL: https://issues.apache.org/jira/browse/WICKET-6203
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 8.0.0-M1
>            Reporter: Matthias Metzger
>            Priority: Trivial
>              Labels: newbie
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The IModel#mapWith method actually combines two models using a BiFunction. Thus another name like 'combineWith' would be much more descriptive of the actual task. 
> Furthermore providing the BiFunction to combine the two models as the first argument of 'mapWith'/'combineWith' might obscure the other Model used for longer lambda expressions, since it will be provided after the lambda expression. It might be better to provide the other Model as a first argument.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)