[GitHub] [cordova-plugin-camera] jcesarmobile commented on a change in pull request #510: (android) fix: use provider prefix to avoid conflict with cordova-open plugin

[GitBox <gi...@apache.org>]

jcesarmobile commented on a change in pull request #510:
URL: https://github.com/apache/cordova-plugin-camera/pull/510#discussion_r455706582



##########
File path: plugin.xml
##########
@@ -59,7 +59,7 @@
         <config-file target="AndroidManifest.xml" parent="application">
           <provider
               android:name="org.apache.cordova.camera.FileProvider"
-              android:authorities="${applicationId}.provider"
+              android:authorities="${applicationId}.cordova.plugin.camera.provider"

Review comment:
       I don't think it's breaking, but we are doing a major release anyway, so it won't be a problem anyway. I fixed some conflicts it had, going to merge.
   
   We should probably add a provider in cordova-android for plugins to use instead of each plugin having it's own, but providers need an Android support/Android X dependency, so not sure if we want that in cordova-android.
   If not, just a simple official plugin that only have the provider and others can use as a dependency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org