You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/27 04:16:18 UTC

[GitHub] TisonKun commented on issue #6948: [FLINK-10702][scala-shell] Yarn app is not killed when scala shell is terminated

TisonKun commented on issue #6948: [FLINK-10702][scala-shell] Yarn app is not killed when scala shell is terminated
URL: https://github.com/apache/flink/pull/6948#issuecomment-433589159
 
 
   Looks reasonable. However, recently I am working with FLINK-10392 "Remove legacy mode" and I find `YarnClusterClient` is used by so called legacy mode. A FLIP-6 replacement of it could be `FlinkYarnSessionCli` or `RestClusterClient`. I might prefer to refactor Scala Shell to base on the new client. But well, if we want a hotfix *for now*, this pull request does the job.
   
   cc @tillrohrmann @GJL 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services