You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/12/03 21:38:28 UTC
[GitHub] michellethomas commented on issue #6470: Use
@superset-ui/number-format and @superset-ui/time-format for formatting.
michellethomas commented on issue #6470: Use @superset-ui/number-format and @superset-ui/time-format for formatting.
URL: https://github.com/apache/incubator-superset/pull/6470#issuecomment-443879950
This lgtm
(For a future PR), do you think we should add tests for the backwards compatibility code in setupFormatter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org