You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/05 12:48:55 UTC

[GitHub] [hbase] rvaleti edited a comment on pull request #1857: HBASE-24499 Use a client property for SaslConnection MAX_ATTEMPTS

rvaleti edited a comment on pull request #1857:
URL: https://github.com/apache/hbase/pull/1857#issuecomment-639449166


   > Looks good overall. Does it make sense to also add a small test to cover the configuration?
   
   I tried to look at existing tests for 
   
   > > > This one is only used in BlockingRpcConnection?
   > > 
   > > 
   > > @Apache9 , I did look at NettyRpcConnection as well but I couldn't find references to retries.
   > 
   > Then please put the configuration in BlockingRpcConnection?
   
   Sure, Let me move this to BlockingRpcConnection


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org