You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/09/28 04:48:41 UTC

[kudu-CR] [thirdparty] fix Postgres memset s() build issue on macOS

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24964


Change subject: [thirdparty] fix Postgres memset_s() build issue on macOS
......................................................................

[thirdparty] fix Postgres memset_s() build issue on macOS

This changelist adds an extra patch from PostgreSQL's upstream git repo
to address compilation error on macOS after the recent update in Kudu's
3rd-party to enable building with GCC15 [2]:

  thirdparty/src/postgresql-17.2/src/port/explicit_bzero.c:22:9: error:
        call to undeclared function 'memset_s'; ISO C99 and later do not
        support implicit function declarations
        [-Wimplicit-function-declaration]
     22 |         (void) memset_s(buf, len, 0, len);

[1] https://github.com/postgres/postgres/commit/12eee85e5
[2] https://github.com/apache/kudu/commit/2acbccb8c

Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
---
A thirdparty/patches/postgres-memset_s.patch
M thirdparty/vars.sh
2 files changed, 177 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/24964/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Gerrit-Change-Number: 24964
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [thirdparty] fix Postgres memset s() build issue on macOS

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24964 )

Change subject: [thirdparty] fix Postgres memset_s() build issue on macOS
......................................................................


Patch Set 2: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/3065/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/24964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Gerrit-Change-Number: 24964
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2026 20:14:02 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix Postgres memset s() build issue on macOS

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24964 )

Change subject: [thirdparty] fix Postgres memset_s() build issue on macOS
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Gerrit-Change-Number: 24964
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2026 13:04:58 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix Postgres memset s() build issue on macOS

Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24964 )

Change subject: [thirdparty] fix Postgres memset_s() build issue on macOS
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Gerrit-Change-Number: 24964
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2026 20:32:29 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix Postgres memset s() build issue on macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Zoltan Martonka, Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24964

to look at the new patch set (#2).

Change subject: [thirdparty] fix Postgres memset_s() build issue on macOS
......................................................................

[thirdparty] fix Postgres memset_s() build issue on macOS

This changelist adds an extra patch from PostgreSQL's upstream git repo
to address compilation error on macOS after the recent update in Kudu's
3rd-party to enable building with GCC 15 [2]:

  thirdparty/src/postgresql-17.2/src/port/explicit_bzero.c:22:9: error:
        call to undeclared function 'memset_s'; ISO C99 and later do not
        support implicit function declarations
        [-Wimplicit-function-declaration]
     22 |         (void) memset_s(buf, len, 0, len);

Also, it updates the CFLAGS used to build PostgreSQL: keeping the flags
compatible with GCC 7, it switches the default C standard mode
from C17 to C11, replacing -std=c17 with -std=c11.

[1] https://github.com/postgres/postgres/commit/12eee85e5
[2] https://github.com/apache/kudu/commit/2acbccb8c

Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
---
M thirdparty/build-definitions.sh
A thirdparty/patches/postgres-memset_s.patch
M thirdparty/vars.sh
3 files changed, 183 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/24964/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Gerrit-Change-Number: 24964
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [thirdparty] fix Postgres memset s() build issue on macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24964 )

Change subject: [thirdparty] fix Postgres memset_s() build issue on macOS
......................................................................

[thirdparty] fix Postgres memset_s() build issue on macOS

This changelist adds an extra patch from PostgreSQL's upstream git repo
to address compilation error on macOS after the recent update in Kudu's
3rd-party to enable building with GCC 15 [2]:

  thirdparty/src/postgresql-17.2/src/port/explicit_bzero.c:22:9: error:
        call to undeclared function 'memset_s'; ISO C99 and later do not
        support implicit function declarations
        [-Wimplicit-function-declaration]
     22 |         (void) memset_s(buf, len, 0, len);

Also, it updates the CFLAGS used to build PostgreSQL: keeping the flags
compatible with GCC 7, it switches the default C standard mode
from C17 to C11, replacing -std=c17 with -std=c11.

[1] https://github.com/postgres/postgres/commit/12eee85e5
[2] https://github.com/apache/kudu/commit/2acbccb8c

Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Reviewed-on: http://gerrit.cloudera.org:8080/24964
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
---
M thirdparty/build-definitions.sh
A thirdparty/patches/postgres-memset_s.patch
M thirdparty/vars.sh
3 files changed, 183 insertions(+), 2 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Zoltan Martonka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/24964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Gerrit-Change-Number: 24964
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [thirdparty] fix Postgres memset s() build issue on macOS

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24964 )

Change subject: [thirdparty] fix Postgres memset_s() build issue on macOS
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/3065/


-- 
To view, visit http://gerrit.cloudera.org:8080/24964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Gerrit-Change-Number: 24964
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2026 19:22:12 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix Postgres memset s() build issue on macOS

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24964 )

Change subject: [thirdparty] fix Postgres memset_s() build issue on macOS
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/3051/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/24964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Gerrit-Change-Number: 24964
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 28 Sep 2026 04:49:09 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix Postgres memset s() build issue on macOS

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24964 )

Change subject: [thirdparty] fix Postgres memset_s() build issue on macOS
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/3051/


-- 
To view, visit http://gerrit.cloudera.org:8080/24964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88651ddd056c90c02f65148905c61eb0f4e54f94
Gerrit-Change-Number: 24964
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 28 Sep 2026 04:48:48 +0000
Gerrit-HasComments: No