You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/08/15 12:01:37 UTC
[GitHub] [commons-io] nhojpatrick opened a new pull request #142: Takari maven wrapper
nhojpatrick opened a new pull request #142:
URL: https://github.com/apache/commons-io/pull/142
Maven 3.7.0 will introduce a maven wrapper that is based upon the takari maven wrapper.
The advantage of using a maven wrapper is that it puts the control over what maven version to be use into source control, and each branch or tag controls the version it requires. Both developers and CI/CD no longer have to play russian roulette over what version needs to be installed.
This PR changes mvn CI/CD commands to mvnw include documentation and comments.
I've been using takari for about 4 years and have tested the version which will released as part of maven v3.7.0. Moving to the apache maven version will simply be a case of properties file url which happens for any maven upgrade and the mvnw scripts mainly around the license header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] nhojpatrick closed pull request #142: Takari maven wrapper
Posted by GitBox <gi...@apache.org>.
nhojpatrick closed pull request #142:
URL: https://github.com/apache/commons-io/pull/142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #142: Takari maven wrapper
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #142:
URL: https://github.com/apache/commons-io/pull/142#issuecomment-674389767
[](https://coveralls.io/builds/32776489)
Coverage remained the same at 89.943% when pulling **b14fe3c5b22aca55a66fdf016564b21364170451 on nhojpatrick:takari.maven-wrapper** into **946a5b73fc0b10221e3a36dd98c749b90a571e5b on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] coveralls edited a comment on pull request #142: Takari maven wrapper
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #142:
URL: https://github.com/apache/commons-io/pull/142#issuecomment-674389767
[](https://coveralls.io/builds/32776885)
Coverage increased (+0.06%) to 90.006% when pulling **dae659bf1171ba9caa8bcb4d295a1e7f222d4a0a on nhojpatrick:takari.maven-wrapper** into **946a5b73fc0b10221e3a36dd98c749b90a571e5b on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] nhojpatrick commented on pull request #142: Takari maven wrapper
Posted by GitBox <gi...@apache.org>.
nhojpatrick commented on pull request #142:
URL: https://github.com/apache/commons-io/pull/142#issuecomment-676671251
Withdrawing PR due to negative email voting regarding mvnw as being an improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org