You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/22 23:13:22 UTC

[GitHub] [incubator-tvm] binarybana commented on a change in pull request #6116: [Rust] Some rust cleanups

binarybana commented on a change in pull request #6116:
URL: https://github.com/apache/incubator-tvm/pull/6116#discussion_r459134821



##########
File path: rust/tvm-sys/Cargo.toml
##########
@@ -32,4 +32,4 @@ ndarray = "0.12"
 enumn = "^0.1"
 
 [build-dependencies]
-bindgen = "0.51"
+bindgen = { version="0.51", default-features=false }

Review comment:
       The default-features of `bindgen` pulls in `clap` which has a pretty big (albeit `build-dep`) dependency load. So it'd be good to trim if possible.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org