[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5601: API: Remove source type from Transform

[GitBox <gi...@apache.org>]

stevenzwu commented on code in PR #5601:
URL: https://github.com/apache/iceberg/pull/5601#discussion_r951014590


##########
.palantir/revapi.yml:
##########
@@ -1,6 +1,12 @@
 versionOverrides:
   org.apache.iceberg:iceberg-api:apache-iceberg-0.14.0: "0.14.0"
 acceptedBreaks:
+  apache-iceberg-0.14.0:
+    org.apache.iceberg:iceberg-api:
+    - code: "java.class.defaultSerializationChanged"

Review Comment:
   Just to confirm that this doesn't change the the partition spec string representation, right? That seems to be the case from my quick scan of the PR.
   
   Want to see if it affects the java serialization of `BaseContentScanTask`. 
   ```
     BaseContentScanTask(F file, String schemaString, String specString, ResidualEvaluator residuals)
   ```
   
   This is related to a pending task in the Flink source checkpointing state (both current `FlinkSource` and the new FLIP-27 `IcebergSource`).
   https://github.com/apache/iceberg/issues/1698



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org