[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3194: BP-50: Add reuse journal file feature to support Intel PMem disk

[GitBox <gi...@apache.org>]

StevenLuMT commented on code in PR #3194:
URL: https://github.com/apache/bookkeeper/pull/3194#discussion_r930165047


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java:
##########
@@ -248,6 +257,13 @@ private JournalChannel(File journalDirectory, long logId,
         }
     }
 
+    public static void renameJournalFile(File source, File target) throws IOException {
+        if (!source.renameTo(target)) {

Review Comment:
   I  think you should check source's value like:
   `if (source == null) {
               throw new NullPointerException();
           }`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org