You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/08 07:10:00 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4653: Use ProjectionsContext to process encrypt ResultSetMetaData

terrymanu opened a new pull request #4653: Use ProjectionsContext to process encrypt ResultSetMetaData
URL: https://github.com/apache/incubator-shardingsphere/pull/4653
 
 
   For #4637.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4653: Use ProjectionsContext to process encrypt ResultSetMetaData

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4653: Use ProjectionsContext to process encrypt ResultSetMetaData
URL: https://github.com/apache/incubator-shardingsphere/pull/4653#issuecomment-596175916
 
 
   ## Pull Request Test Coverage Report for [Build 10102](https://coveralls.io/builds/29203826)
   
   * **3** of **11**   **(27.27%)**  changed or added relevant lines in **2** files are covered.
   * **18** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.1%**) to **58.919%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/EncryptResultSetMetaData.java](https://coveralls.io/builds/29203826/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fresultset%2FEncryptResultSetMetaData.java#L89) | 1 | 9 | 11.11%
   <!-- | **Total:** | **3** | **11** | **27.27%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29203826/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29203826/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29203826/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% |
   <!-- | **Total:** | **18** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29203826/badge)](https://coveralls.io/builds/29203826) |
   | :-- | --: |
   | Change from base [Build 1015](https://coveralls.io/builds/29203745): |  -0.1% |
   | Covered Lines: | 12106 |
   | Relevant Lines: | 20547 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4653: Use ProjectionsContext to process encrypt ResultSetMetaData

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4653: Use ProjectionsContext to process encrypt ResultSetMetaData
URL: https://github.com/apache/incubator-shardingsphere/pull/4653
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4653: Use ProjectionsContext to process encrypt ResultSetMetaData

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4653: Use ProjectionsContext to process encrypt ResultSetMetaData
URL: https://github.com/apache/incubator-shardingsphere/pull/4653#issuecomment-596175916
 
 
   ## Pull Request Test Coverage Report for [Build 2023](https://coveralls.io/builds/29203838)
   
   * **3** of **11**   **(27.27%)**  changed or added relevant lines in **2** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.05%**) to **58.996%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/EncryptResultSetMetaData.java](https://coveralls.io/builds/29203838/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fresultset%2FEncryptResultSetMetaData.java#L89) | 1 | 9 | 11.11%
   <!-- | **Total:** | **3** | **11** | **27.27%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29203838/badge)](https://coveralls.io/builds/29203838) |
   | :-- | --: |
   | Change from base [Build 1015](https://coveralls.io/builds/29203745): |  -0.05% |
   | Covered Lines: | 12122 |
   | Relevant Lines: | 20547 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4653: Use ProjectionsContext to process encrypt ResultSetMetaData

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4653: Use ProjectionsContext to process encrypt ResultSetMetaData
URL: https://github.com/apache/incubator-shardingsphere/pull/4653#issuecomment-596175657
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4653?src=pr&el=h1) Report
   > Merging [#4653](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4653?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/2c1753d4b8f4677bc4b8a998dfd2fc07f8c898ca?src=pr&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `18.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4653/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4653?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4653      +/-   ##
   ============================================
   - Coverage     55.41%   55.36%   -0.06%     
     Complexity      426      426              
   ============================================
     Files          1134     1134              
     Lines         20571    20547      -24     
     Branches       3816     3811       -5     
   ============================================
   - Hits          11400    11376      -24     
     Misses         8453     8453              
     Partials        718      718
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4653?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../jdbc/core/resultset/EncryptResultSetMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4653/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvcmVzdWx0c2V0L0VuY3J5cHRSZXN1bHRTZXRNZXRhRGF0YS5qYXZh) | `3.57% <0%> (-27.2%)` | `0 <0> (ø)` | |
   | [...dingjdbc/jdbc/core/resultset/EncryptResultSet.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4653/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvcmVzdWx0c2V0L0VuY3J5cHRSZXN1bHRTZXQuamF2YQ==) | `21.23% <100%> (-8.13%)` | `0 <0> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4653?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4653?src=pr&el=footer). Last update [2c1753d...eaa1c12](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4653?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services