You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/11 04:39:18 UTC

[GitHub] [pulsar] BewareMyPower commented on issue #7787: [pulsar-client-cpp] Should throw std::exception (or a subtype), not const char*

BewareMyPower commented on issue #7787:
URL: https://github.com/apache/pulsar/issues/7787#issuecomment-671720191


   I agree with you. Throwing a `std::invalid_argument` is a better choice. The pulsar C++ client doesn't use exceptions except for fail-fast, but throwing a `const char*` won't print any message, while throwing an exception would print the message of `what()` method.
   
   Would you like to submit a PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org