[GitHub] [doris] spaces-X commented on a diff in pull request #15713: [refactor] separate agg and flush in memtable

[GitBox <gi...@apache.org>]

spaces-X commented on code in PR #15713:
URL: https://github.com/apache/doris/pull/15713#discussion_r1064256108


##########
be/src/olap/delta_writer.cpp:
##########
@@ -170,14 +170,14 @@ Status DeltaWriter::write(const vectorized::Block* block, const std::vector<int>
     _total_received_rows += row_idxs.size();
     _mem_table->insert(block, row_idxs);
 
-    if (_mem_table->need_to_agg()) {
+    if (_mem_table->need_agg()) {

Review Comment:
   Suggest to add `UNLIKELY` when calling `need_agg` and `need_flush` , since the size of a block is much smaller than 200MB.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org