[GitHub] [commons-lang] garydgregory edited a comment on issue #482: LANG-1504 - Adding steps feature to StopWatch

[GitBox <gi...@apache.org>]

garydgregory edited a comment on issue #482: LANG-1504 - Adding steps feature to StopWatch
URL: https://github.com/apache/commons-lang/pull/482#issuecomment-569841120
 
 
   Since we already have split() we should keep the name. Another idea, is
   that split times should be kept in history list. But then, I'd want a list
   of pairs (message-split time) and it starts to feel like feature creep ;-)
   
   Split history example in Android: https://ibb.co/g9cbGXn
   
   I'm not sure how handy this would as I do not have a use case for it.
   
   I'd like to cut a RC later this week. There is already plenty for a release
   ATM but let's keep the discussion going :-)
   
   Gary
   
   
   On Mon, Dec 30, 2019 at 7:22 PM Rafael Topera <no...@github.com>
   wrote:
   
   > FYI, the conventional name for what you call "step" is "split", sometimes
   > also "lap" (less modern terminology.)
   >
   > I didn`t know that, thanks for sharing :)
   >
   > I take a look now and the StopWatch already has the *split* method, but
   > works in a different way.
   >
   > Some differences:
   >
   >    1.
   >
   >    With *split* we need to call *getSplitTime* while we are in the middle
   >    of split (I mean, before calling *unsplit*). In the "steps" solution
   >    we can get all times in a separated report, at the end of our performance
   >    test, for example.
   >    2.
   >
   >    With *split* we can have just one split each time. With *steps*, many
   >    3.
   >
   >    With *steps* we can label each step with a name
   >    4.
   >
   >    Split counts the time since the StopWatch started, not the time
   >    between splits.
   >    Example
   >
   >    ```
   >
   >
   > final StopWatch sw = StopWatch.createStarted();
   >
   >     Thread.sleep(100);
   >
   >     sw.split();
   >
   >     Thread.sleep(200);
   >
   >     sw.split();
   >
   >     Thread.sleep(400);
   >
   >     System.out.println("splitTime: " + sw.getSplitTime()); // returns 300: the time between start and latest split
   >     System.out.println("time: " + sw.getTime()); // returns 700
   >
   >
   > So, my proposal is to use a new name no change the idea of the old split.
   > Possibilities: **lap** (as you said), **step**, **stage**
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/commons-lang/pull/482?email_source=notifications&email_token=AAJB6N2KGGVNWSYE637EDE3Q3KGE3A5CNFSM4KBARU2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH3P46Y#issuecomment-569835131>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAJB6NYOU656F74UM24RTRLQ3KGE3ANCNFSM4KBARU2A>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services