[GitHub] [incubator-iceberg] rdblue commented on issue #580: Infer mapping from expected schema if file schema does not have field-ids and name mapping is missing

[GitBox <gi...@apache.org>]

rdblue commented on issue #580: Infer mapping from expected schema if file schema does not have field-ids and name mapping is missing
URL: https://github.com/apache/incubator-iceberg/pull/580#issuecomment-546737660
 
 
   Thanks @rdsr! Looks good.
   
   I think that the logic should be that if any ID is assigned, we don't use fallback assignment. We have to assume that if a file has any explicit ID then it was written with IDs. I think I got the logic wrong in the Parquet fallback. We should fix that as well (though not in this PR).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org