You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/06 07:05:20 UTC
[GitHub] [shardingsphere] strongduanmu opened a new issue, #17375: Add more unit test for FederationDatabaseMetaData
strongduanmu opened a new issue, #17375:
URL: https://github.com/apache/shardingsphere/issues/17375
Hi community,
This issue is for [OpenForce](https://github.com/apache/shardingsphere/discussions/12683#discussioncomment-2139441)
We need to add more unit test for FederationDatabaseMetaData.
- [ ] FederationDatabaseMetaData#putSchemaMetadata
- [ ] FederationDatabaseMetaData#putTableMetadata
- [ ] FederationDatabaseMetaData#removeSchemaMetadata
- [ ] FederationDatabaseMetaData#removeTableMetadata
- [ ] FederationDatabaseMetaData#getSchemaMetadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] aoyvx commented on issue #17375: [WeOpen-Star] Add more unit test for FederationDatabaseMetaData
Posted by GitBox <gi...@apache.org>.
aoyvx commented on issue #17375:
URL: https://github.com/apache/shardingsphere/issues/17375#issuecomment-1139436887
@strongduanmu Hello, what should I do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #17375: [WeOpen-Star] Add more unit test for FederationDatabaseMetaData
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #17375:
URL: https://github.com/apache/shardingsphere/issues/17375#issuecomment-1139483327
> getSchemaMetadata
@aoyvx Can you show your test code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] aoyvx commented on issue #17375: [WeOpen-Star] Add more unit test for FederationDatabaseMetaData
Posted by GitBox <gi...@apache.org>.
aoyvx commented on issue #17375:
URL: https://github.com/apache/shardingsphere/issues/17375#issuecomment-1128512375
@strongduanmu hi,I was testing the getSchemaMetadata method when I raised a `NullPointerException`.Do you think you should use `Optional.ofNullable()` as the return value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] aoyvx commented on issue #17375: [WeOpen-Star] Add more unit test for FederationDatabaseMetaData
Posted by GitBox <gi...@apache.org>.
aoyvx commented on issue #17375:
URL: https://github.com/apache/shardingsphere/issues/17375#issuecomment-1139665251
> @aoyvx Can you show your test code?
@strongduanmu The following test case can pass, but I'm not sure if it meets the expectations. Complete code in https://github.com/apache/shardingsphere/compare/master...aoyvx:features/FederationDatabaseMetaDataTest.
```
@Test(expected = NullPointerException.class)
public void assertGetSchemaMetadataByNonexistentKey() {
final ShardingSphereSchema sphereSchema = mock(ShardingSphereSchema.class);
final Map<String, ShardingSphereSchema> map = Maps.of("foo_db", sphereSchema);
final FederationDatabaseMetaData federationDatabaseMetaData = new FederationDatabaseMetaData("foo", map);
federationDatabaseMetaData.getSchemaMetadata("foo_db_2");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #17375: [WeOpen-Star] Add more unit test for FederationDatabaseMetaData
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #17375:
URL: https://github.com/apache/shardingsphere/issues/17375#issuecomment-1181573130
Fixed by #18542.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #17375: [WeOpen-Star] Add more unit test for FederationDatabaseMetaData
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #17375:
URL: https://github.com/apache/shardingsphere/issues/17375#issuecomment-1164025490
What is the stack trace？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu closed issue #17375: [WeOpen-Star] Add more unit test for FederationDatabaseMetaData
Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #17375: [WeOpen-Star] Add more unit test for FederationDatabaseMetaData
URL: https://github.com/apache/shardingsphere/issues/17375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #17375: [WeOpen-Star] Add more unit test for FederationDatabaseMetaData
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #17375:
URL: https://github.com/apache/shardingsphere/issues/17375#issuecomment-1124939613
@aoyvx Welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] aoyvx commented on issue #17375: [WeOpen-Star] Add more unit test for FederationDatabaseMetaData
Posted by GitBox <gi...@apache.org>.
aoyvx commented on issue #17375:
URL: https://github.com/apache/shardingsphere/issues/17375#issuecomment-1124671674
Assign me, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org