You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/04/18 23:40:51 UTC
[kudu-CR] [master] modernize code w.r.t. virtual/override keywords
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13066
Change subject: [master] modernize code w.r.t. virtual/override keywords
......................................................................
[master] modernize code w.r.t. virtual/override keywords
This patch does not contain any functional modifications.
Change-Id: Ibf5871424f569e50bb3cae9d1554ba4c02b8372c
---
M src/kudu/master/master-test.cc
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_service.h
M src/kudu/master/sys_catalog-test.cc
4 files changed, 76 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/13066/1
--
To view, visit http://gerrit.cloudera.org:8080/13066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf5871424f569e50bb3cae9d1554ba4c02b8372c
Gerrit-Change-Number: 13066
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [master] modernize code w.r.t. virtual/override keywords
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13066 )
Change subject: [master] modernize code w.r.t. virtual/override keywords
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5871424f569e50bb3cae9d1554ba4c02b8372c
Gerrit-Change-Number: 13066
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 19 Apr 2019 04:28:13 +0000
Gerrit-HasComments: No
[kudu-CR] [master] modernize code w.r.t. virtual/override keywords
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13066 )
Change subject: [master] modernize code w.r.t. virtual/override keywords
......................................................................
[master] modernize code w.r.t. virtual/override keywords
This patch does not contain any functional modifications.
Change-Id: Ibf5871424f569e50bb3cae9d1554ba4c02b8372c
Reviewed-on: http://gerrit.cloudera.org:8080/13066
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/master/master-test.cc
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_service.h
M src/kudu/master/sys_catalog-test.cc
4 files changed, 76 insertions(+), 72 deletions(-)
Approvals:
Alexey Serbin: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf5871424f569e50bb3cae9d1554ba4c02b8372c
Gerrit-Change-Number: 13066
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [master] modernize code w.r.t. virtual/override keywords
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [master] modernize code w.r.t. virtual/override keywords
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ibf5871424f569e50bb3cae9d1554ba4c02b8372c
Gerrit-Change-Number: 13066
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [master] modernize code w.r.t. virtual/override keywords
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13066 )
Change subject: [master] modernize code w.r.t. virtual/override keywords
......................................................................
Patch Set 1: Verified+1
Unrelated flake in ToolTest.TestGetFlags
--
To view, visit http://gerrit.cloudera.org:8080/13066
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5871424f569e50bb3cae9d1554ba4c02b8372c
Gerrit-Change-Number: 13066
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 19 Apr 2019 00:14:24 +0000
Gerrit-HasComments: No