You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "jak78 (via GitHub)" <gi...@apache.org> on 2023/12/17 21:16:23 UTC
[PR] [doc][client feature matrix] improve experience for .NET users looking for information on .NET/C# clients [pulsar-site]
jak78 opened a new pull request, #754:
URL: https://github.com/apache/pulsar-site/pull/754
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
-->
This PR aims to improve the experience for .NET/C# users looking for information on .NET/C# clients. The goal is to help the users choose which client best suits their needs.
Two .NET clients exist: C#/DotPulsar and .NET client. They don't provide the same feature coverage. The PR fixes the client features matrix to display the two clients side by side to highlight this coverage difference.
Additionally, the PR adds a link to the client docs to facilitate the navigation and help the user compare the two clients in details.
Finally, the PR makes the doc use the same names for the clients in both the feature matrix and the client libraries page to improve clarity.
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc][client feature matrix] improve experience for .NET users looking for information on .NET/C# clients [pulsar-site]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #754:
URL: https://github.com/apache/pulsar-site/pull/754#discussion_r1430220155
##########
client-feature-matrix/index.mdx:
##########
@@ -14,6 +14,8 @@ import {
tableview,
} from "../data/matrix.js";
+To get more information on clients, see [Pulsar Client Libraries](/docs/next/client-libraries).
Review Comment:
> it results in a 404 error
The redirect happens in Apache Web Server. So perhaps you need run docker-compose for previewing this manner ..
https://github.com/apache/pulsar-site/blob/80e4090e04dbbbf22652be38d542e4989d8dc3bd/static/.htaccess#L19
https://github.com/apache/pulsar-site/blob/main/docker-compose.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc][client feature matrix] improve experience for .NET users looking for information on .NET/C# clients [pulsar-site]
Posted by "jak78 (via GitHub)" <gi...@apache.org>.
jak78 commented on code in PR #754:
URL: https://github.com/apache/pulsar-site/pull/754#discussion_r1430278387
##########
client-feature-matrix/index.mdx:
##########
@@ -14,6 +14,8 @@ import {
tableview,
} from "../data/matrix.js";
+To get more information on clients, see [Pulsar Client Libraries](/docs/next/client-libraries).
Review Comment:
Same result using docker compose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc][client feature matrix] improve experience for .NET users looking for information on .NET/C# clients [pulsar-site]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #754:
URL: https://github.com/apache/pulsar-site/pull/754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc][client feature matrix] improve experience for .NET users looking for information on .NET/C# clients [pulsar-site]
Posted by "jak78 (via GitHub)" <gi...@apache.org>.
jak78 commented on code in PR #754:
URL: https://github.com/apache/pulsar-site/pull/754#discussion_r1430206400
##########
client-feature-matrix/index.mdx:
##########
@@ -14,6 +14,8 @@ import {
tableview,
} from "../data/matrix.js";
+To get more information on clients, see [Pulsar Client Libraries](/docs/next/client-libraries).
Review Comment:
Looks like you can remove the `next` part from the links on the `md` pages but not on the `mdx` pages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc][client feature matrix] improve experience for .NET users looking for information on .NET/C# clients [pulsar-site]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #754:
URL: https://github.com/apache/pulsar-site/pull/754#discussion_r1430280799
##########
client-feature-matrix/index.mdx:
##########
@@ -14,6 +14,8 @@ import {
tableview,
} from "../data/matrix.js";
+To get more information on clients, see [Pulsar Client Libraries](/docs/next/client-libraries).
Review Comment:
Well. I'll merge as is now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc][client feature matrix] improve experience for .NET users looking for information on .NET/C# clients [pulsar-site]
Posted by "jak78 (via GitHub)" <gi...@apache.org>.
jak78 commented on PR #754:
URL: https://github.com/apache/pulsar-site/pull/754#issuecomment-1860778262
Thank you @tisonkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc][client feature matrix] improve experience for .NET users looking for information on .NET/C# clients [pulsar-site]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #754:
URL: https://github.com/apache/pulsar-site/pull/754#discussion_r1430172727
##########
client-feature-matrix/index.mdx:
##########
@@ -14,6 +14,8 @@ import {
tableview,
} from "../data/matrix.js";
+To get more information on clients, see [Pulsar Client Libraries](/docs/next/client-libraries).
Review Comment:
```suggestion
To get more information on clients, see [Pulsar Client Libraries](/docs/client-libraries).
```
Let's use latest stable version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc][client feature matrix] improve experience for .NET users looking for information on .NET/C# clients [pulsar-site]
Posted by "jak78 (via GitHub)" <gi...@apache.org>.
jak78 commented on code in PR #754:
URL: https://github.com/apache/pulsar-site/pull/754#discussion_r1430202270
##########
client-feature-matrix/index.mdx:
##########
@@ -14,6 +14,8 @@ import {
tableview,
} from "../data/matrix.js";
+To get more information on clients, see [Pulsar Client Libraries](/docs/next/client-libraries).
Review Comment:
I tried that, but it results in a 404 error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org