You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by kerrishotts <gi...@git.apache.org> on 2016/11/18 21:52:46 UTC
[GitHub] cordova-ios pull request #280: CB-12155: Create automated tests for launch s...
GitHub user kerrishotts opened a pull request:
https://github.com/apache/cordova-ios/pull/280
CB-12155: Create automated tests for launch storyboard feature
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
- iOS
### What does this PR do?
Tests the launch storyboard feature introduced by CB-9762.
### What testing has been done on this change?
Tests have been tested with `npm run unit-tests`
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
- Note: some tests are marked as [PENDING]; need to pull CB-12084 in before those can be finished
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kerrishotts/cordova-ios CB-12155
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #280
----
commit 222a76265bf28ac3a393b2c5ee1045a2669864eb
Author: Kerri Shotts <ks...@apache.org>
Date: 2016-11-18T21:43:40Z
CB-12155: Let there be storyboard tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #280: CB-12155: Create automated tests for launch s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/280
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #280: CB-12155: Create automated tests for launch storyboa...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/280
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/280?src=pr) is 61.96% (diff: 100%)
> Merging [#280](https://codecov.io/gh/apache/cordova-ios/pull/280?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will increase coverage by **1.73%**
```diff
@@ master #280 diff @@
==========================================
Files 12 12
Lines 1325 1325
Methods 202 202
Messages 0 0
Branches 224 224
==========================================
+ Hits 798 821 +23
+ Misses 527 504 -23
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [99219c1...d908f6f](https://codecov.io/gh/apache/cordova-ios/compare/99219c1c4cd8d1000fb89a15449f2d25a57bef41...d908f6ffcada998cc05db17b36957244a80cf7a2?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #280: CB-12155: Create automated tests for launch storyboa...
Posted by kerrishotts <gi...@git.apache.org>.
Github user kerrishotts commented on the issue:
https://github.com/apache/cordova-ios/pull/280
Let there be tests... :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #280: CB-12155: Create automated tests for launch storyboa...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/280
I think the tests are failing because of these lines:
1. https://github.com/apache/cordova-ios/blob/99219c1c4cd8d1000fb89a15449f2d25a57bef41/bin/templates/scripts/cordova/lib/prepare.js#L700
2. https://github.com/apache/cordova-ios/blob/99219c1c4cd8d1000fb89a15449f2d25a57bef41/bin/templates/scripts/cordova/lib/prepare.js#L736
You need to join the projectRoot as well as the first parameter, I believe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #280: CB-12155: Create automated tests for launch storyboa...
Posted by kerrishotts <gi...@git.apache.org>.
Github user kerrishotts commented on the issue:
https://github.com/apache/cordova-ios/pull/280
@shazron: Thanks -- I noticed that. I've got a patch for it in CB-12084 which I'm going to pull in first, which should clear up the existing issues. Then I need add a couple more tests for the changes in CB-12084. Once done, this should be good-to-go for 4.3.1 assuming nothing else crops up. ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org