[GitHub] [hive] ngsg commented on pull request #4323: HIVE-27344: Add a null check in RecordReaderImpl.close()

["ngsg (via GitHub)" <gi...@apache.org>]

ngsg commented on PR #4323:
URL: https://github.com/apache/hive/pull/4323#issuecomment-1594511556

   @deniskuzZ  It is hard to add a test case for reproducing the issue because it deeply depends on ORC implementation, especially on the constructor ORC's RecordReaderImpl. The original situation we faced also depends on HADOOP-16109 issue, so it won't be appear with Hadoop releases on which HADOOP-16109 patch is applied. As this issue deeply depends on the outside of Hive and the patch is just a kind of defensive programming, I suggest not adding a test case to reproduce the problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org