You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2023/01/06 01:01:21 UTC
[GitHub] [hadoop] tomscut commented on a diff in pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath
tomscut commented on code in PR #5276:
URL: https://github.com/apache/hadoop/pull/5276#discussion_r1063015972
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java:
##########
@@ -97,6 +99,8 @@
private final TreeMap<String, MountTable> tree = new TreeMap<>();
/** Path -> Remote location. */
private final Cache<String, PathLocation> locationCache;
+ public static LongAdder locCacheMissed = new LongAdder();
+ public static LongAdder locCacheAccessed = new LongAdder();
Review Comment:
Those metrics make sense to me.
One little advice: update `locCacheMissed` to `locCacheMiss`, and update `locCacheAccessed` to `locCacheHit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org