You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Charith Dhanushka Wickramarachchi (JIRA)" <ji...@apache.org> on 2009/08/11 05:54:15 UTC

[jira] Created: (WSCOMMONS-494) Unit Test for the SMSTransport

Unit Test for the SMSTransport
------------------------------

                 Key: WSCOMMONS-494
                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-494
             Project: WS-Commons
          Issue Type: Improvement
         Environment: any
            Reporter: Charith Dhanushka Wickramarachchi
            Priority: Minor


The SMS Transport currently does not have any test cases.I'll provide a patch that will add the Unit test for the SMS transport

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-494) Unit Test for the SMSTransport

Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741901#action_12741901 ] 

Amila Chinthaka Suriarachchi commented on WSCOMMONS-494:
--------------------------------------------------------

I ran the unit test in my machine got some exceptions

> Unit Test for the SMSTransport
> ------------------------------
>
>                 Key: WSCOMMONS-494
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-494
>             Project: WS-Commons
>          Issue Type: Improvement
>         Environment: any
>            Reporter: Charith Dhanushka Wickramarachchi
>            Priority: Minor
>         Attachments: 11-08-2009-sms-transport-test.patch
>
>
> The SMS Transport currently does not have any test cases.I'll provide a patch that will add the Unit test for the SMS transport

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WSCOMMONS-494) Unit Test for the SMSTransport

Posted by "Charith Dhanushka Wickramarachchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charith Dhanushka Wickramarachchi updated WSCOMMONS-494:
--------------------------------------------------------

    Attachment: 19-08-2009-sms-transport-test.patch

> Unit Test for the SMSTransport
> ------------------------------
>
>                 Key: WSCOMMONS-494
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-494
>             Project: WS-Commons
>          Issue Type: Improvement
>         Environment: any
>            Reporter: Charith Dhanushka Wickramarachchi
>            Priority: Minor
>         Attachments: 11-08-2009-sms-transport-test.patch, 17-08-2009-sms-transport-test.patch, 18-08-2009-sms-transport-test.patch, 19-08-2009-sms-transport-test.patch, org.apache.axis2.transport.sms.SMSTransportTest.txt
>
>
> The SMS Transport currently does not have any test cases.I'll provide a patch that will add the Unit test for the SMS transport

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WSCOMMONS-494) Unit Test for the SMSTransport

Posted by "Charith Dhanushka Wickramarachchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charith Dhanushka Wickramarachchi updated WSCOMMONS-494:
--------------------------------------------------------

    Attachment: 18-08-2009-sms-transport-test.patch

Hi,

The above patch will fix the issue.Now it will success in -Dtest=fasle / -Dmaven.test.skip=true

I'm normally use mvn clean install -Dtest=false to skip the tests.But As i understand the maven antRun plugin threat mvn clean install -Dtest=false and -Dmaven.test.skip=true in a different way. 

# When we use the -Dtest=false to skip the tests it will do not compile test classes and also does not run the ant tasks that we have defined in the "test-compile " phase.(So in this case -Dtest=false will be successful)

# But when we use the -Dmaven.test.skip=ture to skip the tests it does not compile the test cases as above But the different is it will execute the ant tasks that are defined in the "test-compile" phase (Thats why it gaves a error since it will try to copy a class file that is not created)


NOTE that the patch will contain the services.xml , MANIFEST.MF , axis2.xml  too since it seems that they are not added to the trunk which were included in the previous patch(that files are need to for the test cases).

thanks,
Charith



> Unit Test for the SMSTransport
> ------------------------------
>
>                 Key: WSCOMMONS-494
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-494
>             Project: WS-Commons
>          Issue Type: Improvement
>         Environment: any
>            Reporter: Charith Dhanushka Wickramarachchi
>            Priority: Minor
>         Attachments: 11-08-2009-sms-transport-test.patch, 17-08-2009-sms-transport-test.patch, 18-08-2009-sms-transport-test.patch, org.apache.axis2.transport.sms.SMSTransportTest.txt
>
>
> The SMS Transport currently does not have any test cases.I'll provide a patch that will add the Unit test for the SMS transport

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WSCOMMONS-494) Unit Test for the SMSTransport

Posted by "Charith Dhanushka Wickramarachchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charith Dhanushka Wickramarachchi updated WSCOMMONS-494:
--------------------------------------------------------

    Attachment: 11-08-2009-sms-transport-test.patch

I have attached the Integration test for the SMPP implementation of the SMS Transport.
Please review and commit.

> Unit Test for the SMSTransport
> ------------------------------
>
>                 Key: WSCOMMONS-494
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-494
>             Project: WS-Commons
>          Issue Type: Improvement
>         Environment: any
>            Reporter: Charith Dhanushka Wickramarachchi
>            Priority: Minor
>         Attachments: 11-08-2009-sms-transport-test.patch
>
>
> The SMS Transport currently does not have any test cases.I'll provide a patch that will add the Unit test for the SMS transport

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WSCOMMONS-494) Unit Test for the SMSTransport

Posted by "Charith Dhanushka Wickramarachchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charith Dhanushka Wickramarachchi updated WSCOMMONS-494:
--------------------------------------------------------

    Attachment: 17-08-2009-sms-transport-test.patch

Hi,

The previous exception is due to a threading issue.So i modified the code to overcome that issue.

that exception comes since the SimpleSMSC simulator does get started properly before sending the SMS to it.

please review and commit.

thanks,
Charith.

> Unit Test for the SMSTransport
> ------------------------------
>
>                 Key: WSCOMMONS-494
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-494
>             Project: WS-Commons
>          Issue Type: Improvement
>         Environment: any
>            Reporter: Charith Dhanushka Wickramarachchi
>            Priority: Minor
>         Attachments: 11-08-2009-sms-transport-test.patch, 17-08-2009-sms-transport-test.patch, org.apache.axis2.transport.sms.SMSTransportTest.txt
>
>
> The SMS Transport currently does not have any test cases.I'll provide a patch that will add the Unit test for the SMS transport

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WSCOMMONS-494) Unit Test for the SMSTransport

Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amila Chinthaka Suriarachchi updated WSCOMMONS-494:
---------------------------------------------------

    Attachment: org.apache.axis2.transport.sms.SMSTransportTest.txt

error file

> Unit Test for the SMSTransport
> ------------------------------
>
>                 Key: WSCOMMONS-494
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-494
>             Project: WS-Commons
>          Issue Type: Improvement
>         Environment: any
>            Reporter: Charith Dhanushka Wickramarachchi
>            Priority: Minor
>         Attachments: 11-08-2009-sms-transport-test.patch, org.apache.axis2.transport.sms.SMSTransportTest.txt
>
>
> The SMS Transport currently does not have any test cases.I'll provide a patch that will add the Unit test for the SMS transport

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WSCOMMONS-494) Unit Test for the SMSTransport

Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amila Chinthaka Suriarachchi resolved WSCOMMONS-494.
----------------------------------------------------

    Resolution: Fixed

Applied the patch

> Unit Test for the SMSTransport
> ------------------------------
>
>                 Key: WSCOMMONS-494
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-494
>             Project: WS-Commons
>          Issue Type: Improvement
>         Environment: any
>            Reporter: Charith Dhanushka Wickramarachchi
>            Priority: Minor
>         Attachments: 11-08-2009-sms-transport-test.patch, 17-08-2009-sms-transport-test.patch, 18-08-2009-sms-transport-test.patch, 19-08-2009-sms-transport-test.patch, org.apache.axis2.transport.sms.SMSTransportTest.txt
>
>
> The SMS Transport currently does not have any test cases.I'll provide a patch that will add the Unit test for the SMS transport

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-494) Unit Test for the SMSTransport

Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744562#action_12744562 ] 

Amila Chinthaka Suriarachchi commented on WSCOMMONS-494:
--------------------------------------------------------

committed the patch.

Now with out tests it gives an error. i.e. with mvn clean install -Dmaven.test.skip=true -o

[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] An Ant BuildException has occured: Warning: Could not find file /home/amila/projects/transport/modules/sms/target/test-classes/org/apache/axis2/transport/sms/SimpleInOutMessageReceiver.class to copy.


can you fix this too?

> Unit Test for the SMSTransport
> ------------------------------
>
>                 Key: WSCOMMONS-494
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-494
>             Project: WS-Commons
>          Issue Type: Improvement
>         Environment: any
>            Reporter: Charith Dhanushka Wickramarachchi
>            Priority: Minor
>         Attachments: 11-08-2009-sms-transport-test.patch, 17-08-2009-sms-transport-test.patch, org.apache.axis2.transport.sms.SMSTransportTest.txt
>
>
> The SMS Transport currently does not have any test cases.I'll provide a patch that will add the Unit test for the SMS transport

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.