You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org> on 2005/08/03 19:46:34 UTC

[jira] Created: (GERONIMO-847) Better error for unmapped resource reference

Better error for unmapped resource reference
--------------------------------------------

         Key: GERONIMO-847
         URL: http://issues.apache.org/jira/browse/GERONIMO-847
     Project: Geronimo
        Type: Improvement
  Components: web, deployment, naming  
    Versions: 1.0-M4    
    Reporter: Aaron Mulder
     Fix For: 1.0-M5


When you add a resource-ref to web.xml but not geronimo-web.xml, you get an error like:

Error: Unable to distribute foo.war: Unknown or ambiguous
connection factory name query:
geronimo.server:J2EEServer=geronimo,J2EEApplication=null,j2eeType=JCAManagedConnectionFactory,
name=jms/TestConnectionFactory,*
match count: 0

It would be better if the error said "Unable to resolve resource-ref 'jms/TestConnectionFactory'".  I believe a similar change was made eslerwhere recently, just need to track down the specifics.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-847) Better error for unmapped resource reference

Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-847?page=all ]

Matt Hogstrom updated GERONIMO-847:
-----------------------------------

    Fix Version: 1.x
                     (was: 1.0)

> Better error for unmapped resource reference
> --------------------------------------------
>
>          Key: GERONIMO-847
>          URL: http://issues.apache.org/jira/browse/GERONIMO-847
>      Project: Geronimo
>         Type: Improvement
>   Components: deployment, naming, web
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>      Fix For: 1.x

>
> When you add a resource-ref to web.xml but not geronimo-web.xml, you get an error like:
> Error: Unable to distribute foo.war: Unknown or ambiguous
> connection factory name query:
> geronimo.server:J2EEServer=geronimo,J2EEApplication=null,j2eeType=JCAManagedConnectionFactory,
> name=jms/TestConnectionFactory,*
> match count: 0
> It would be better if the error said "Unable to resolve resource-ref 'jms/TestConnectionFactory'".  It looks like there's a good message if you provide an invalid mapping value in geronimo-web.xml, but not a good message if you do not provide any mapping in geronimo-web.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-847) Better error for unmapped resource reference

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-847?page=all ]
     
David Jencks closed GERONIMO-847:
---------------------------------

    Resolution: Fixed
     Assign To: David Jencks  (was: Aaron Mulder)

Applied, thanks for the patch!

> Better error for unmapped resource reference
> --------------------------------------------
>
>          Key: GERONIMO-847
>          URL: http://issues.apache.org/jira/browse/GERONIMO-847
>      Project: Geronimo
>         Type: Improvement
>     Security: public(Regular issues) 
>   Components: deployment, naming, web
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>     Assignee: David Jencks
>     Priority: Critical
>      Fix For: 1.1
>  Attachments: 847-resource-ref-error-msg.patch
>
> When you add a resource-ref to web.xml but not geronimo-web.xml, you get an error like:
> Error: Unable to distribute foo.war: Unknown or ambiguous
> connection factory name query:
> geronimo.server:J2EEServer=geronimo,J2EEApplication=null,j2eeType=JCAManagedConnectionFactory,
> name=jms/TestConnectionFactory,*
> match count: 0
> It would be better if the error said "Unable to resolve resource-ref 'jms/TestConnectionFactory'".  It looks like there's a good message if you provide an invalid mapping value in geronimo-web.xml, but not a good message if you do not provide any mapping in geronimo-web.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-847) Better error for unmapped resource reference

Posted by "Erin Mulder (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-847?page=all ]

Erin Mulder updated GERONIMO-847:
---------------------------------

    Attachment: 847-resource-ref-error-msg.patch

This patch updates ConnectorModuleBuilder to throw an UnresolvedReferenceException and updates ENCConfigBuilder to give more helpful and specific error messages for the following error conditions:

   1) Multiple matches found, no mapping in geronimo deployment plan

   2) Multiple matches found, ambiguous mapping in geronimo deployment plan

   3) No match found, no mapping in geronimo deployment plan

   4) No match found, incorrect mapping in geronimo deployment plan

> Better error for unmapped resource reference
> --------------------------------------------
>
>          Key: GERONIMO-847
>          URL: http://issues.apache.org/jira/browse/GERONIMO-847
>      Project: Geronimo
>         Type: Improvement
>     Security: public(Regular issues) 
>   Components: deployment, naming, web
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>     Assignee: Aaron Mulder
>     Priority: Critical
>      Fix For: 1.1
>  Attachments: 847-resource-ref-error-msg.patch
>
> When you add a resource-ref to web.xml but not geronimo-web.xml, you get an error like:
> Error: Unable to distribute foo.war: Unknown or ambiguous
> connection factory name query:
> geronimo.server:J2EEServer=geronimo,J2EEApplication=null,j2eeType=JCAManagedConnectionFactory,
> name=jms/TestConnectionFactory,*
> match count: 0
> It would be better if the error said "Unable to resolve resource-ref 'jms/TestConnectionFactory'".  It looks like there's a good message if you provide an invalid mapping value in geronimo-web.xml, but not a good message if you do not provide any mapping in geronimo-web.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-847) Better error for unmapped resource reference

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-847?page=all ]

Aaron Mulder updated GERONIMO-847:
----------------------------------

    Description: 
When you add a resource-ref to web.xml but not geronimo-web.xml, you get an error like:

Error: Unable to distribute foo.war: Unknown or ambiguous
connection factory name query:
geronimo.server:J2EEServer=geronimo,J2EEApplication=null,j2eeType=JCAManagedConnectionFactory,
name=jms/TestConnectionFactory,*
match count: 0

It would be better if the error said "Unable to resolve resource-ref 'jms/TestConnectionFactory'".  It looks like there's a good message if you provide an invalid mapping value in geronimo-web.xml, but not a good message if you do not provide any mapping in geronimo-web.xml.

  was:
When you add a resource-ref to web.xml but not geronimo-web.xml, you get an error like:

Error: Unable to distribute foo.war: Unknown or ambiguous
connection factory name query:
geronimo.server:J2EEServer=geronimo,J2EEApplication=null,j2eeType=JCAManagedConnectionFactory,
name=jms/TestConnectionFactory,*
match count: 0

It would be better if the error said "Unable to resolve resource-ref 'jms/TestConnectionFactory'".  I believe a similar change was made eslerwhere recently, just need to track down the specifics.


> Better error for unmapped resource reference
> --------------------------------------------
>
>          Key: GERONIMO-847
>          URL: http://issues.apache.org/jira/browse/GERONIMO-847
>      Project: Geronimo
>         Type: Improvement
>   Components: deployment, naming, web
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>      Fix For: 1.0-M5

>
> When you add a resource-ref to web.xml but not geronimo-web.xml, you get an error like:
> Error: Unable to distribute foo.war: Unknown or ambiguous
> connection factory name query:
> geronimo.server:J2EEServer=geronimo,J2EEApplication=null,j2eeType=JCAManagedConnectionFactory,
> name=jms/TestConnectionFactory,*
> match count: 0
> It would be better if the error said "Unable to resolve resource-ref 'jms/TestConnectionFactory'".  It looks like there's a good message if you provide an invalid mapping value in geronimo-web.xml, but not a good message if you do not provide any mapping in geronimo-web.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-847) Better error for unmapped resource reference

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-847?page=comments#action_12377023 ] 

David Jencks commented on GERONIMO-847:
---------------------------------------

umm, that was rev 398028

> Better error for unmapped resource reference
> --------------------------------------------
>
>          Key: GERONIMO-847
>          URL: http://issues.apache.org/jira/browse/GERONIMO-847
>      Project: Geronimo
>         Type: Improvement
>     Security: public(Regular issues) 
>   Components: deployment, naming, web
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>     Assignee: David Jencks
>     Priority: Critical
>      Fix For: 1.1
>  Attachments: 847-resource-ref-error-msg.patch
>
> When you add a resource-ref to web.xml but not geronimo-web.xml, you get an error like:
> Error: Unable to distribute foo.war: Unknown or ambiguous
> connection factory name query:
> geronimo.server:J2EEServer=geronimo,J2EEApplication=null,j2eeType=JCAManagedConnectionFactory,
> name=jms/TestConnectionFactory,*
> match count: 0
> It would be better if the error said "Unable to resolve resource-ref 'jms/TestConnectionFactory'".  It looks like there's a good message if you provide an invalid mapping value in geronimo-web.xml, but not a good message if you do not provide any mapping in geronimo-web.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-847) Better error for unmapped resource reference

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-847?page=all ]

Aaron Mulder updated GERONIMO-847:
----------------------------------

    Fix Version: 1.1
                     (was: 1.x)
      Assign To: Aaron Mulder
       Priority: Critical  (was: Major)

Check what happens in 1.1.

> Better error for unmapped resource reference
> --------------------------------------------
>
>          Key: GERONIMO-847
>          URL: http://issues.apache.org/jira/browse/GERONIMO-847
>      Project: Geronimo
>         Type: Improvement
>     Security: public(Regular issues) 
>   Components: deployment, naming, web
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>     Assignee: Aaron Mulder
>     Priority: Critical
>      Fix For: 1.1

>
> When you add a resource-ref to web.xml but not geronimo-web.xml, you get an error like:
> Error: Unable to distribute foo.war: Unknown or ambiguous
> connection factory name query:
> geronimo.server:J2EEServer=geronimo,J2EEApplication=null,j2eeType=JCAManagedConnectionFactory,
> name=jms/TestConnectionFactory,*
> match count: 0
> It would be better if the error said "Unable to resolve resource-ref 'jms/TestConnectionFactory'".  It looks like there's a good message if you provide an invalid mapping value in geronimo-web.xml, but not a good message if you do not provide any mapping in geronimo-web.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-847) Better error for unmapped resource reference

Posted by "David Blevins (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-847?page=all ]

David Blevins updated GERONIMO-847:
-----------------------------------

    Fix Version: 1.0
                     (was: 1.0-M5)

> Better error for unmapped resource reference
> --------------------------------------------
>
>          Key: GERONIMO-847
>          URL: http://issues.apache.org/jira/browse/GERONIMO-847
>      Project: Geronimo
>         Type: Improvement
>   Components: deployment, naming, web
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>      Fix For: 1.0

>
> When you add a resource-ref to web.xml but not geronimo-web.xml, you get an error like:
> Error: Unable to distribute foo.war: Unknown or ambiguous
> connection factory name query:
> geronimo.server:J2EEServer=geronimo,J2EEApplication=null,j2eeType=JCAManagedConnectionFactory,
> name=jms/TestConnectionFactory,*
> match count: 0
> It would be better if the error said "Unable to resolve resource-ref 'jms/TestConnectionFactory'".  It looks like there's a good message if you provide an invalid mapping value in geronimo-web.xml, but not a good message if you do not provide any mapping in geronimo-web.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira