You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Arvind Prabhakar <ar...@apache.org> on 2011/10/07 04:31:15 UTC

Review Request: Fix for SQOOP-359

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2270/
-----------------------------------------------------------

Review request for Sqoop and Bilung Lee.


Summary
-------

Modified TestBoundaryQuery to introduce a test that reproduces this problem. Also added a validation exception that is raised when the user uses a boundary query without specifying a split-by column.


This addresses bug SQOOP-359.
    https://issues.apache.org/jira/browse/SQOOP-359


Diffs
-----

  /src/java/com/cloudera/sqoop/manager/SqlManager.java 1178856 
  /src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1178856 
  /src/test/com/cloudera/sqoop/TestBoundaryQuery.java 1178856 

Diff: https://reviews.apache.org/r/2270/diff


Testing
-------

All unit and thirdparty tests.


Thanks,

Arvind


Re: Review Request: Fix for SQOOP-359

Posted by Arvind Prabhakar <ar...@apache.org>.

> On 2011-10-07 21:01:09, Arvind Prabhakar wrote:
> > /src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java, line 177
> > <https://reviews.apache.org/r/2270/diff/1/?file=48568#file48568line177>
> >
> >     I could do that but then I will have to do a null check in DataDrivenDBInputFormat. Otherwise, the following code will raise a NPE. Hence I kept it separate. If ou think that is better, I can certainly change that. Please let me know.

I think I misunderstood your comment. I will update the patch to remove the redundant check. Thanks for pointing that out.


- Arvind


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2270/#review2442
-----------------------------------------------------------


On 2011-10-07 02:31:15, Arvind Prabhakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2270/
> -----------------------------------------------------------
> 
> (Updated 2011-10-07 02:31:15)
> 
> 
> Review request for Sqoop and Bilung Lee.
> 
> 
> Summary
> -------
> 
> Modified TestBoundaryQuery to introduce a test that reproduces this problem. Also added a validation exception that is raised when the user uses a boundary query without specifying a split-by column.
> 
> 
> This addresses bug SQOOP-359.
>     https://issues.apache.org/jira/browse/SQOOP-359
> 
> 
> Diffs
> -----
> 
>   /src/java/com/cloudera/sqoop/manager/SqlManager.java 1178856 
>   /src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1178856 
>   /src/test/com/cloudera/sqoop/TestBoundaryQuery.java 1178856 
> 
> Diff: https://reviews.apache.org/r/2270/diff
> 
> 
> Testing
> -------
> 
> All unit and thirdparty tests.
> 
> 
> Thanks,
> 
> Arvind
> 
>


Re: Review Request: Fix for SQOOP-359

Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2270/#review2442
-----------------------------------------------------------



/src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java
<https://reviews.apache.org/r/2270/#comment5551>

    I could do that but then I will have to do a null check in DataDrivenDBInputFormat. Otherwise, the following code will raise a NPE. Hence I kept it separate. If ou think that is better, I can certainly change that. Please let me know.


- Arvind


On 2011-10-07 02:31:15, Arvind Prabhakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2270/
> -----------------------------------------------------------
> 
> (Updated 2011-10-07 02:31:15)
> 
> 
> Review request for Sqoop and Bilung Lee.
> 
> 
> Summary
> -------
> 
> Modified TestBoundaryQuery to introduce a test that reproduces this problem. Also added a validation exception that is raised when the user uses a boundary query without specifying a split-by column.
> 
> 
> This addresses bug SQOOP-359.
>     https://issues.apache.org/jira/browse/SQOOP-359
> 
> 
> Diffs
> -----
> 
>   /src/java/com/cloudera/sqoop/manager/SqlManager.java 1178856 
>   /src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1178856 
>   /src/test/com/cloudera/sqoop/TestBoundaryQuery.java 1178856 
> 
> Diff: https://reviews.apache.org/r/2270/diff
> 
> 
> Testing
> -------
> 
> All unit and thirdparty tests.
> 
> 
> Thanks,
> 
> Arvind
> 
>


Re: Review Request: Fix for SQOOP-359

Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2270/#review2456
-----------------------------------------------------------

Ship it!


- Bilung


On 2011-10-07 23:04:25, Arvind Prabhakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2270/
> -----------------------------------------------------------
> 
> (Updated 2011-10-07 23:04:25)
> 
> 
> Review request for Sqoop and Bilung Lee.
> 
> 
> Summary
> -------
> 
> Modified TestBoundaryQuery to introduce a test that reproduces this problem. Also added a validation exception that is raised when the user uses a boundary query without specifying a split-by column.
> 
> 
> This addresses bug SQOOP-359.
>     https://issues.apache.org/jira/browse/SQOOP-359
> 
> 
> Diffs
> -----
> 
>   /src/java/com/cloudera/sqoop/manager/SqlManager.java 1180266 
>   /src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1180266 
>   /src/test/com/cloudera/sqoop/TestBoundaryQuery.java 1180266 
> 
> Diff: https://reviews.apache.org/r/2270/diff
> 
> 
> Testing
> -------
> 
> All unit and thirdparty tests.
> 
> 
> Thanks,
> 
> Arvind
> 
>


Re: Review Request: Fix for SQOOP-359

Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2270/
-----------------------------------------------------------

(Updated 2011-10-07 23:04:25.276941)


Review request for Sqoop and Bilung Lee.


Changes
-------

Updating patch with review feedback.


Summary
-------

Modified TestBoundaryQuery to introduce a test that reproduces this problem. Also added a validation exception that is raised when the user uses a boundary query without specifying a split-by column.


This addresses bug SQOOP-359.
    https://issues.apache.org/jira/browse/SQOOP-359


Diffs (updated)
-----

  /src/java/com/cloudera/sqoop/manager/SqlManager.java 1180266 
  /src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1180266 
  /src/test/com/cloudera/sqoop/TestBoundaryQuery.java 1180266 

Diff: https://reviews.apache.org/r/2270/diff


Testing
-------

All unit and thirdparty tests.


Thanks,

Arvind


Re: Review Request: Fix for SQOOP-359

Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2270/#review2441
-----------------------------------------------------------


Thanks for the patch.  Look good overall.  One suggestion below.


/src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java
<https://reviews.apache.org/r/2270/#comment5547>

    Would it be better to have this if clause inside the previous if clause? So you won't go through it twice if inputBoundingQuery is already not null.


- Bilung


On 2011-10-07 02:31:15, Arvind Prabhakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2270/
> -----------------------------------------------------------
> 
> (Updated 2011-10-07 02:31:15)
> 
> 
> Review request for Sqoop and Bilung Lee.
> 
> 
> Summary
> -------
> 
> Modified TestBoundaryQuery to introduce a test that reproduces this problem. Also added a validation exception that is raised when the user uses a boundary query without specifying a split-by column.
> 
> 
> This addresses bug SQOOP-359.
>     https://issues.apache.org/jira/browse/SQOOP-359
> 
> 
> Diffs
> -----
> 
>   /src/java/com/cloudera/sqoop/manager/SqlManager.java 1178856 
>   /src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1178856 
>   /src/test/com/cloudera/sqoop/TestBoundaryQuery.java 1178856 
> 
> Diff: https://reviews.apache.org/r/2270/diff
> 
> 
> Testing
> -------
> 
> All unit and thirdparty tests.
> 
> 
> Thanks,
> 
> Arvind
> 
>