You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/07/04 08:07:13 UTC

[GitHub] [echarts] plainheart opened a new pull request, #17308: fix(custom): fix custom elements probably can't be removed due to NPE when applying leave transition

plainheart opened a new pull request, #17308:
URL: https://github.com/apache/echarts/pull/17308

   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Fix potential null pointer exception when applying leave transition on removed elements.
   
   ### Fixed issues
   
   - Resolves #17185
   
   ## Details
   
   ### Before: What was the problem?
   
   The elements probably can't be removed due to the unexpected NPE when applying leave transition.
   
   ![image](https://user-images.githubusercontent.com/26999792/177109770-0f6d2dd3-cb3a-4da2-9594-6e57709d6451.png)
   
   ### After: How does it behave after the fixing?
   
   Detect if the targeted element exists before applying leave transition.
   
   ![image](https://user-images.githubusercontent.com/26999792/177109927-77a23a7a-da87-4c65-ab5e-33b0cc5d512a.png)
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   ## Misc
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   Please refer to the first case in `test/custom.html`
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17308: fix(custom): fix custom elements probably can't be removed due to NPE when applying leave transition

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17308:
URL: https://github.com/apache/echarts/pull/17308#issuecomment-1173491127

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17308: fix(custom): fix custom elements probably can't be removed due to NPE when applying leave transition

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17308:
URL: https://github.com/apache/echarts/pull/17308#issuecomment-1173599619

   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ovilia merged pull request #17308: fix(custom): fix custom elements probably can't be removed due to NPE when applying leave transition

Posted by GitBox <gi...@apache.org>.
Ovilia merged PR #17308:
URL: https://github.com/apache/echarts/pull/17308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org