[GitHub] [pulsar] Pomelongan commented on a diff in pull request #17816: [improve][broker]add return for PersistentMessageExpiryMonitor#findEntryFailed

[GitBox <gi...@apache.org>]

Pomelongan commented on code in PR #17816:
URL: https://github.com/apache/pulsar/pull/17816#discussion_r979527238


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java:
##########
@@ -192,6 +192,7 @@ public void findEntryFailed(ManagedLedgerException exception, Optional<Position>
             log.warn("[{}][{}] read failed from ledger at position:{} : {}", topicName, subName, failedReadPosition,
                     exception.getMessage());
             findEntryComplete(failedReadPosition.get(), ctx);
+            return;

Review Comment:
   Thanks for reviewing. The findEntryComplete method will change the `expirationCheckInProgress` to FALSE. If return is not added, the updateRates method will execute repeatedly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org