[GitHub] [hbase] ndimiduk commented on a change in pull request #2017: HBASE-24669 Logging of ppid should be consistent across all occurrences

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #2017:
URL: https://github.com/apache/hbase/pull/2017#discussion_r450379754



##########
File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
##########
@@ -1842,7 +1842,7 @@ private void countDownChildren(RootProcedureState<TEnvironment> procStack,
       store.update(parent);
       scheduler.addFront(parent);
       LOG.info("Finished subprocedure pid={}, resume processing parent {}",
-          procedure.getProcId(), parent);
+          procedure.getProcId(), parent.toString().replace("pid=","ppid="));

Review comment:
       Oh, I see. Good find. How about `"Finished subprocedure (pid={}), resume processing of parent (ppid={})`, and use `parent.getProcId()` instead of the string replace.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org